fix(ENGKNOW-3485): Fix varnorm shifting N vars to far.#120
Open
gmagnu wants to merge 5 commits into
Open
Conversation
gmagnu
commented
May 31, 2026
gmagnu
commented
Contributor
- Fixed varnorm shifting N var to far (removed old incorrect fix for N and did it correctly)
- Added tests
The two "N in refSeq stops outer loop" tests claimed the outer repeat-extension loop stops via an "explicit != 'N' guard". No such guard exists. The outer loop compares two refSeq bases exactly L apart (L = indel length = repeat period), so at the repeat->N boundary the leading base is 'N' while its partner is still a non-N repeat base -> the loop stops by mismatch, not a guard. Period-L spacing makes the outer loop inherently N-safe; only the inner loops needed the guard. Comment-only change. All 52 UTestVarnormAnalysis tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.