Repository navigation
Commit 2e301dd
fix(share_plus): only configure popover presentation on iPad
Since Xcode 26, `UIActivityViewController.popoverPresentationController` is
non-nil on iPhone as well, where it returns a private
`_UIActivityViewControllerPresentationController` instead of a real
`UIPopoverPresentationController`.
The plugin set `sourceView` unconditionally and, on iPhone with a non-empty
`sharePositionOrigin`, also set `sourceRect`. Both configure anchored
presentation on a controller that is not a popover controller on iPhone.
Restrict every popover configuration to iPad, which is what the surrounding
comment already stated as the intent. iPad behaviour, including the
centre-of-view fallback added in #3769, is unchanged.1 parent 3151839 commit 2e301dd
1 file changed
Lines changed: 10 additions & 10 deletions
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
411 | 411 | | |
412 | 412 | | |
413 | 413 | | |
414 | | - | |
415 | | - | |
416 | | - | |
417 | 414 | | |
418 | 415 | | |
419 | 416 | | |
420 | | - | |
421 | | - | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
422 | 423 | | |
423 | 424 | | |
424 | | - | |
425 | 425 | | |
426 | | - | |
427 | | - | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
428 | 429 | | |
429 | 430 | | |
| 431 | + | |
430 | 432 | | |
431 | 433 | | |
432 | 434 | | |
| |||
438 | 440 | | |
439 | 441 | | |
440 | 442 | | |
441 | | - | |
442 | | - | |
443 | 443 | | |
444 | 444 | | |
445 | 445 | | |
| |||
0 commit comments