Skip to content

Code Quality: Shared tag registry storage - #19053

Merged
yair100 merged 1 commit into
files-community:mainfrom
hez2010:feature/server-shared-tags
Oct 26, 2026
Merged

yair100 merged 1 commit into
files-community:mainfrom
hez2010:feature/server-shared-tags

Conversation

@hez2010

@hez2010 hez2010 commented Oct 21, 2026

Copy link
Copy Markdown
Member

Share the registry storage between server and apps for the upcoming server migration work.

Depends on #19051

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@hez2010
hez2010 force-pushed the feature/server-shared-tags branch 6 times, most recently from a6e496f to d190b52 Compare October 26, 2026 13:39
@hez2010
hez2010 marked this pull request as ready for review October 26, 2026 13:57
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-26T13:57:19.564514Z
We couldn’t complete this review. Comment @codex review to try again.
d190b52 Draft marked ready
🔒 Security Review ⚠️ Failed 2026-10-26T13:57:26.408068Z
We couldn’t complete this review. Comment @codex security review to try again.
d190b52 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

@hez2010

hez2010 commented Oct 26, 2026 •

Copy link
Copy Markdown
Member Author

@yair100 This is the 2nd of 3 fundamental work to land the server infra. Please take a look.

@hez2010
hez2010 force-pushed the feature/server-shared-tags branch from d190b52 to 2457752 Compare October 26, 2026 14:05

@yair100 yair100 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yair100 yair100 added the ready to merge Pull requests that are approved and ready to merge label Oct 26, 2026
@yair100
yair100 merged commit 8e104dc into files-community:main Oct 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants