Skip to content

Commit 11c3593

Browse files
committed
updating the requirement Ids based on the new feature requirements
1 parent 57843f6 commit 11c3593

4 files changed

Lines changed: 13 additions & 16 deletions

File tree

‎feature_integration_tests/test_cases/BUILD‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,8 @@ score_py_pytest(
188188
deps = all_requirements,
189189
)
190190

191-
# Dedicated, isolated coverage for ready_recovery_action.restart.number_of_attempts
192-
# (feat_req__lifecycle__retries_configurable). Each daemon invocation generates its own
193-
# single-component config and runtime tree under TEST_TMPDIR.
191+
# Dedicated, isolated coverage for ready_recovery_action.restart.number_of_attempts. Each daemon
192+
# invocation generates its own single-component config and runtime tree under TEST_TMPDIR.
194193
score_py_pytest(
195194
name = "fit_lifecycle_retries",
196195
timeout = "long",

‎feature_integration_tests/test_cases/tests/lifecycle/test_conditional_launching.py‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,8 @@ class TestConditionalLaunchingBlocksOnMissingDependency:
5858

5959
@add_test_properties(
6060
partially_verifies=[
61-
"feat_req__lifecycle__waitfor_support",
62-
"feat_req__lifecycle__dependency_check",
61+
"feat_req__lifecycle__conditional_startup",
6362
"feat_req__lifecycle__process_ordering",
64-
"feat_req__lifecycle__define_swc_dependencies",
6563
],
6664
test_type="requirements-based",
6765
derivation_technique="requirements-analysis",
@@ -73,8 +71,8 @@ def test_rust_stays_down_until_cpp_dependency_becomes_available(
7371
launch failure at least twice (it keeps retrying rather than aborting). After cpp is made
7472
executable, cpp and then rust must be running within 8 s each.
7573
76-
Limitations: "running" is pgrep process existence; rust has a single dependency, so
77-
`dependency_check` ("all dependencies") cannot be told apart from "any dependency".
74+
Limitations: "running" is pgrep process existence; rust has a single dependency, so this
75+
does not distinguish single-edge gating from multi-dependency behavior.
7876
No `cond_process_start` claim: that requirement is about starting on the return value
7977
of earlier processes, which this config does not use.
8078
"""

‎feature_integration_tests/test_cases/tests/lifecycle/test_process_launching_with_daemon.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def test_startup_declares_and_launches_multiple_processes(
148148
assert daemon.is_running(), "Launch Manager daemon stopped unexpectedly"
149149

150150
@add_test_properties(
151-
partially_verifies=["feat_req__lifecycle__process_launch_args"],
151+
partially_verifies=["feat_req__lifecycle__launch_support"],
152152
test_type="requirements-based",
153153
derivation_technique="requirements-analysis",
154154
)
@@ -182,7 +182,7 @@ def test_launch_process_arguments_are_applied(
182182
)
183183

184184
@add_test_properties(
185-
partially_verifies=["feat_req__lifecycle__process_launch_args"],
185+
partially_verifies=["feat_req__lifecycle__launch_support"],
186186
test_type="requirements-based",
187187
derivation_technique="requirements-analysis",
188188
)
@@ -214,7 +214,7 @@ def test_launch_process_environment_is_applied(
214214
f"{key} mismatch for {app_name}: expected {expected_value!r}, got {proc_env.get(key)!r}"
215215
)
216216

217-
# No requirement claim (feat_req__lifecycle__uid_gid_support): skips in CI, which neither sets
217+
# No requirement claim: skips in CI, which neither sets
218218
# FIT_ENABLE_SETCAP=1 nor runs unsandboxed, both needed for the setcap grant. See README.md.
219219
def test_launched_process_uid_gid_matches_config_when_applied(
220220
self,
@@ -371,7 +371,7 @@ def test_scheduling_policy_is_non_default_and_applied(
371371
)
372372

373373
@add_test_properties(
374-
partially_verifies=["feat_req__lifecycle__secpol_non_root"],
374+
partially_verifies=["feat_req__lifecycle__launch_support"],
375375
test_type="requirements-based",
376376
derivation_technique="requirements-analysis",
377377
)

‎feature_integration_tests/test_cases/tests/lifecycle/test_retry_exhaustion.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
- `TestRetryExhaustionTriggersRecovery`: the app always crashes; the daemon must stop after
2020
1 + `number_of_attempts` launches and stay alive.
2121
22-
Limitation for `retries_configurable`: only the single configured value (2) is exercised; the
23-
count is not varied across runs.
22+
Limitation: only the single configured retry value (2) is exercised; the count is not varied
23+
across runs.
2424
"""
2525

2626
from __future__ import annotations
@@ -51,7 +51,7 @@ class TestRetrySucceedsWithinConfiguredAttempts(RetryDaemonScenario):
5151
crashes_before_success = 2
5252

5353
@add_test_properties(
54-
partially_verifies=["feat_req__lifecycle__retries_configurable"],
54+
partially_verifies=["feat_req__lifecycle__launch_support"],
5555
test_type="requirements-based",
5656
derivation_technique="requirements-analysis",
5757
)
@@ -88,7 +88,7 @@ class TestRetryExhaustionTriggersRecovery(RetryDaemonScenario):
8888
crashes_before_success = 999
8989

9090
@add_test_properties(
91-
partially_verifies=["feat_req__lifecycle__retries_configurable"],
91+
partially_verifies=["feat_req__lifecycle__launch_support"],
9292
test_type="requirements-based",
9393
derivation_technique="requirements-analysis",
9494
)

0 commit comments

Comments
 (0)