Auto-Buyer consumes faction currency without actually purchasing upgrades

[Tigerlyly]

I couldn't find a version number for the game, but the tab was opened 8/2 ~14:00 Pacific and hasn't been reloaded.

Fortunately it's not game breaking as I can exclude factions from the auto-buy with the filters, but every time I've tried to auto-buy with faction cards in the mix, it'll deduct the currency and not give the upgrade, multiple times even.

[ppokorski22]

So, in all honesty I used Copilot + some troubleshooting, but I did get it to solve the problem.

if (effects.autobuySpeed) {
    autobuyTime += delta / 1000 * effects.autobuySpeed;
    let autobuyCount = Math.floor(autobuyTime);
    autobuyTime -= autobuyCount;
    let upgradedAny = false;
    while (autobuyCount > 0 && tabs.collection.cardList.length > 0) {
        let [pack, rarity, id] = tabs.collection.cardList[0];
        let canBought = getCardLevelMax(pack, rarity, id);
        if (canBought > 0) {
            let buyAmount = Math.min(canBought, autobuyCount);
            autobuyCount -= buyAmount;
            game.stats.autobuyBought += buyAmount;
            levelUpCard(pack, rarity, id, buyAmount, false, false);
            tabs.collection.updateCards(); // refresh cardList immediately after
            upgradedAny = true;
        } else {
            break;
        }
    }
    if (upgradedAny) {
        updateEffects();
        updateUnlocks();
        emit("card-upgrade");
    }
}

Based on the explanation given: "The original auto-buyer logic used a static card list and batch upgrades, which could cause missed upgrades or wasted resources if the list and actual card state got out of sync during the loop. The new solution refreshes the card list after every upgrade, always working on current data, which prevents these issues and makes autobuying reliable for all cards, especially for edge cases like special/faction cards with low resources."

It was in fact somewhat inconsistent. Sometimes to upgrade worked. I believe this was applying to ALL cards (not just faction), but was simply not very noticeable with standard cards due to how many upgrades on how many cards you were doing in comparison.

This 'solution' is slightly slower than original code, but not (currently) to a level that's a problem.

For anybody that wants to test this out before this gets fixed in the source (I should probably create a PR?) you can go into your browser dev options -> sources -> find logic.js and replace lines 65-88 with the above. Save as override to keep active after refreshing etc.

[veber-alex]

I am having the this problem in the game now.
The solution posted works but it's too slow, sometimes there isn't enough time to complete all the upgrades.
Edit: looks like it feels better at higher TPS

[wesleyjnewcomb]

My PR #61 should fix this issue.

This is a much more pervasive bug than it first appears. The root issue was that it was attempting to buy 0 cards when the framerate was fast. At 30 buys/second and 75 frames/sec, there could be two frames before processed before a legitimate buy could occur. With the bug, during those two frames, it would attempt to buy 0 cards and the calculation of the cost would return the cost for buying 1 card. So it would subtract the cost from your resource count and then increment the level by the number you bought: zero.

#47 also fixes the issue but changes the approach and has possible performance issues. #59 does not fix this issue, but fixes another math error.
My PR keeps with the original approach but just fixes the bug.