Repository navigation
Commit bd13e0a
committed
fix(diffsinger): keep rest-note midi/pitch values instead of zeroing
Rest notes had note_midi and ph_midi forced to 0. In all-rest segments the
nearest-fill pass has no non-rest neighbor to overwrite them, so models
received zero midi and either predicted degenerate durations/pitch or failed
outright. Always seed from the original key (pitch also adds cents/100) and
keep isRest masks + nearest fill untouched.1 parent e9ba379 commit bd13e0a
2 files changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
271 | | - | |
272 | | - | |
273 | | - | |
| 271 | + | |
| 272 | + | |
274 | 273 | | |
275 | 274 | | |
276 | 275 | | |
| |||
0 commit comments