Skip to content

Commit 814435e

Browse files
authored
Show module path when logging tasks (#42)
1 parent 9ded401 commit 814435e

1 file changed

Lines changed: 20 additions & 4 deletions

File tree

‎threadmill/executor.py‎

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -229,11 +229,19 @@ def retry_delay(task_result: TaskResult) -> datetime.timedelta | None:
229229
try:
230230
return task_result.task.retry(TaskContext(task_result=task_result))
231231
except Exception:
232-
logger.exception("Retry callback failed for task %r", task_result.id)
232+
logger.exception(
233+
"Retry callback failed for task '%s@%s'",
234+
task_result.id,
235+
task_result.task.module_path,
236+
)
233237

234238
def execute_task_result(self, task_result: TaskResult) -> TaskResult:
235239
"""Execute task from task result and update result lifecycle state."""
236-
logger.info("Executing task %r", task_result.id)
240+
logger.info(
241+
"Executing task '%s@%s'",
242+
task_result.id,
243+
task_result.task.module_path,
244+
)
237245
started_at = timezone.now()
238246
task_result = dataclasses.replace(
239247
task_result,
@@ -252,7 +260,11 @@ def execute_task_result(self, task_result: TaskResult) -> TaskResult:
252260
errors=[*task_result.errors, WorkerThread.create_task_error(exception)],
253261
finished_at=timezone.now(),
254262
)
255-
logger.exception("Task failed %r", task_result.id)
263+
logger.exception(
264+
"Task '%s@%s' failed",
265+
task_result.id,
266+
task_result.task.module_path,
267+
)
256268
else:
257269
task_result = dataclasses.replace(
258270
task_result,
@@ -262,7 +274,11 @@ def execute_task_result(self, task_result: TaskResult) -> TaskResult:
262274
object.__setattr__(
263275
task_result, "_return_value", normalize_json(return_value)
264276
)
265-
logger.info("Task successful %r", task_result.id)
277+
logger.info(
278+
"Task '%s@%s' succeeded",
279+
task_result.id,
280+
task_result.task.module_path,
281+
)
266282
finally:
267283
task_finished.send(TaskExecutor, task_result=task_result)
268284

0 commit comments

Comments
 (0)