Skip to content

Commit 8f89dbe

Browse files
fix: build x86_64 linux binary against glibc 2.31 (#738)
PR #725 dropped the Dockerized ubuntu:20.04 x86_64 build and started building codecovcli_linux on the ubuntu-22.04 runner (glibc 2.35), breaking the binary on older distros such as AL2023 (glibc 2.34). Restore the ubuntu:20.04 x86_64 build in the Dockerized job following the pre-#725 pattern (wildcard codecovcli_* path, glibc compatibility notes), and use file_glob so build_linux.sh's renamed output is published as the canonical codecovcli_linux asset.
1 parent d77ab3b commit 8f89dbe

1 file changed

Lines changed: 9 additions & 12 deletions

File tree

‎.github/workflows/build_assets.yml‎

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,6 @@ jobs:
2929
lipo -archs dist/codecovcli_macos | grep 'x86_64 arm64'
3030
OUT_FILE_NAME: codecovcli_macos
3131

32-
- os: ubuntu-22.04
33-
TARGET: ubuntu
34-
CMD_BUILD: >
35-
uv run pyinstaller -F codecov_cli/main.py &&
36-
cp ./dist/main ./dist/codecovcli_linux
37-
OUT_FILE_NAME: codecovcli_linux
38-
3932
- os: windows-latest
4033
TARGET: windows
4134
CMD_BUILD: >
@@ -85,18 +78,22 @@ jobs:
8578
strategy:
8679
matrix:
8780
include:
88-
- distro: "alpine:3.14"
81+
- distro: "alpine:3.14" # alpine 3.14 needed for musl 1.2.2/python 3.9 compatibility
8982
arch: arm64
9083
distro_name: alpine
9184
runs-on: ubuntu-24.04-arm
9285
- distro: "alpine:3.14"
9386
arch: x86_64
9487
distro_name: alpine
9588
runs-on: ubuntu-24.04
96-
- distro: "ubuntu:20.04"
89+
- distro: "ubuntu:20.04" # ubuntu 20.04 needed for glibc 2.31/python 3.9 compatibility
9790
arch: arm64
9891
distro_name: linux
9992
runs-on: ubuntu-24.04-arm
93+
- distro: "ubuntu:20.04"
94+
arch: x86_64
95+
distro_name: linux
96+
runs-on: ubuntu-24.04
10097

10198
steps:
10299
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
@@ -116,14 +113,14 @@ jobs:
116113
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
117114
with:
118115
name: codecovcli_${{ matrix.distro_name }}_${{ matrix.arch }}
119-
path: ./dist/codecovcli_${{ matrix.distro_name }}_${{ matrix.arch }}
116+
path: ./dist/codecovcli_*
120117

121118
- name: Upload Release Asset
122119
if: inputs.release == true
123120
uses: svenstaro/upload-release-action@81c65b7cd4de9b2570615ce3aad67a41de5b1a13 # v2.11.2
124121
with:
125122
repo_token: ${{ secrets.GITHUB_TOKEN }}
126-
file: ./dist/codecovcli_${{ matrix.distro_name }}_${{ matrix.arch }}
127-
asset_name: codecovcli_${{ matrix.distro_name }}_${{ matrix.arch }}
123+
file: ./dist/codecovcli_*
124+
file_glob: true
128125
tag: ${{ github.ref }}
129126
overwrite: true

0 commit comments

Comments
 (0)