Skip to content
This repository was archived by the owner on Apr 6, 2021. It is now read-only.
This repository was archived by the owner on Apr 6, 2021. It is now read-only.

Transport disconnect does not have reason for a stream connection. #19

Description

@LiamKarlMitchell

in smith.js Transport onDisconnect

self.emit("disconnect")
is not going to pass any sort of reason.

Maybe the function needs to have err as its first parameter and then self.emit("disconnect", err)

The problem is happening on a friends computer so I can't debug to prove it just yet but will try to get a working example later.

Thought I should raise issue just in case it is something that was neglected.
The documentation seems to say onDisconnect event would have a reason. But it is not always the case?.

See these lines.
https://github.com/c9/smith/blob/master/smith.js#L113-127

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions