Skip to content

feat: rework spinner to use Prompt api#479

Open
43081j wants to merge 15 commits into
mainfrom
good-spinner
Open

feat: rework spinner to use Prompt api#479
43081j wants to merge 15 commits into
mainfrom
good-spinner

Conversation

@43081j

@43081j 43081j commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

This reworks the spinner to be based on the Prompt class and have a core prompt like the others do.

It should solve a few rendering bugs/inconsistencies.

DRAFT until i have chance to fix tests up

@changeset-bot

changeset-bot Bot commented Mar 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6ff6b63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clack/prompts Minor
@clack/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Apr 8, 2026

Copy link
Copy Markdown

commit: 6ff6b63

@43081j 43081j marked this pull request as ready for review April 8, 2026 20:56

@natemoo-re natemoo-re left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! One thing that regresses here is when pressing Enter we're getting frames spammed to the console. Seems like we could add special handling for this—I remember fixing that with the previous implementation

Image

this.#message = msg;
}

this.state = 'cancel';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do this.state = 'submit' when the exitCode === 0? Currently this would treat every exit as cancel.

Comment thread .changeset/empty-bananas-melt.md Outdated
@43081j

43081j commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator Author

@dreyfus92 @natemoo-re FYI this is blocked because it has brought the ol' windows bug back.

we still haven't figured out how to fix that bug properly in main. the proposed fix in main introduces the other windows bug.

so this branch has pretty much the same issues until i can figure out the right solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants