|
15 | 15 | # limitations under the License. |
16 | 16 |
|
17 | 17 | setup() { |
18 | | - TEST_TMPDIR=$(mktemp -d) |
19 | | - export TEST_TMPDIR |
20 | | - export OUTPUT_DIR="${TEST_TMPDIR}/report" |
21 | | - mkdir -p "${TEST_TMPDIR}/bin" "${OUTPUT_DIR}" |
22 | | - echo 9 > "${OUTPUT_DIR}/failures" |
23 | | - export MAVEN_EXIT_CODE=1 |
24 | | -cat > "${TEST_TMPDIR}/bin/mvn" <<'EOF' |
25 | | -#!/usr/bin/env bash |
26 | | -rm -rf "${OUTPUT_DIR}" |
27 | | -printf '%s\n' "$*" > "${TEST_TMPDIR}/mvn-args" |
28 | | -printf '%s\n' \ |
29 | | - "[WARNING] The following options were not recognized by any processor: '[artifactId]'" \ |
30 | | - "[WARNING] /src/Legacy.java:[1,1] [JdkObsolete] legacy finding" \ |
31 | | - "[WARNING] /src/Custom.java:[3,1] [Custom-Rule_1] custom finding" \ |
32 | | - "[ERROR] /src/Format.java:[2,1] [FormatString] error finding" \ |
33 | | - "[ERROR] /src/Format.java:[2,1] [FormatString] error finding" \ |
34 | | - "/src/Raw.java:4: warning: [RawWarning] raw warning" \ |
35 | | - "[ERROR] Failed to execute goal example:example: failed" |
36 | | -printf '%s\n' "/src/Raw.java:5: error: [RawError] raw error" >&2 |
37 | | -exit "${MAVEN_EXIT_CODE}" |
38 | | -EOF |
39 | | - chmod +x "${TEST_TMPDIR}/bin/mvn" |
40 | | - export PATH="${TEST_TMPDIR}/bin:${PATH}" |
| 18 | + REPORT_DIR=$(mktemp -d) |
| 19 | + export REPORT_DIR |
41 | 20 | } |
42 | 21 |
|
43 | 22 | teardown() { |
44 | | - rm -rf "${TEST_TMPDIR}" |
| 23 | + rm -rf "${REPORT_DIR}" |
45 | 24 | } |
46 | 25 |
|
47 | 26 | @test "Error Prone reports Maven and javac findings and fails for errors" { |
48 | | - run hadoop-ozone/dev-support/checks/errorprone.sh |
| 27 | + export rc=1 |
| 28 | + cat > "${REPORT_DIR}/output.log" <<'EOF' |
| 29 | +[WARNING] The following options were not recognized by any processor: '[artifactId]' |
| 30 | +[WARNING] /src/Legacy.java:[1,1] [JdkObsolete] legacy finding |
| 31 | +[WARNING] /src/Custom.java:[3,1] [Custom-Rule_1] custom finding |
| 32 | +[ERROR] /src/Format.java:[2,1] [FormatString] error finding |
| 33 | +[ERROR] /src/Format.java:[2,1] [FormatString] error finding |
| 34 | +/src/Raw.java:4: warning: [RawWarning] raw warning |
| 35 | +/src/Raw.java:5: error: [RawError] raw error |
| 36 | +[ERROR] Failed to execute goal example:example: failed |
| 37 | +EOF |
| 38 | + |
| 39 | + run hadoop-ozone/dev-support/checks/_errorprone_report.sh |
49 | 40 |
|
50 | 41 | [ "$status" -eq 1 ] |
51 | | - grep -q -- '-DskipTests' "${TEST_TMPDIR}/mvn-args" |
52 | | - grep -q -- '-DskipShade' "${TEST_TMPDIR}/mvn-args" |
53 | | - grep -q -- 'clean package' "${TEST_TMPDIR}/mvn-args" |
54 | | - [ "$(wc -l < "${OUTPUT_DIR}/diagnostics.txt")" -eq 5 ] |
55 | | - grep -q '^\[WARNING\].*\[JdkObsolete\]' "${OUTPUT_DIR}/diagnostics.txt" |
56 | | - grep -q '^\[ERROR\].*\[FormatString\]' "${OUTPUT_DIR}/diagnostics.txt" |
57 | | - grep -q '^\[WARNING\].*\[Custom-Rule_1\]' "${OUTPUT_DIR}/diagnostics.txt" |
58 | | - grep -q '^/src/Raw.java:4: warning: \[RawWarning\]' "${OUTPUT_DIR}/diagnostics.txt" |
59 | | - grep -q '^/src/Raw.java:5: error: \[RawError\]' "${OUTPUT_DIR}/diagnostics.txt" |
60 | | - ! grep -q 'Failed to execute goal' "${OUTPUT_DIR}/diagnostics.txt" |
61 | | - [ "$(wc -l < "${OUTPUT_DIR}/summary.txt")" -eq 2 ] |
62 | | - grep -q '^\[ERROR\].*\[FormatString\]' "${OUTPUT_DIR}/summary.txt" |
63 | | - grep -q '^/src/Raw.java:5: error: \[RawError\]' "${OUTPUT_DIR}/summary.txt" |
64 | | - [ "$(< "${OUTPUT_DIR}/failures")" -eq 2 ] |
| 42 | + [ "$(wc -l < "${REPORT_DIR}/diagnostics.txt")" -eq 5 ] |
| 43 | + grep -q '^\[WARNING\].*\[JdkObsolete\]' "${REPORT_DIR}/diagnostics.txt" |
| 44 | + grep -q '^\[ERROR\].*\[FormatString\]' "${REPORT_DIR}/diagnostics.txt" |
| 45 | + grep -q '^\[WARNING\].*\[Custom-Rule_1\]' "${REPORT_DIR}/diagnostics.txt" |
| 46 | + grep -q '^/src/Raw.java:4: warning: \[RawWarning\]' "${REPORT_DIR}/diagnostics.txt" |
| 47 | + grep -q '^/src/Raw.java:5: error: \[RawError\]' "${REPORT_DIR}/diagnostics.txt" |
| 48 | + ! grep -q 'Failed to execute goal' "${REPORT_DIR}/diagnostics.txt" |
| 49 | + [ "$(wc -l < "${REPORT_DIR}/summary.txt")" -eq 2 ] |
| 50 | + grep -q '^\[ERROR\].*\[FormatString\]' "${REPORT_DIR}/summary.txt" |
| 51 | + grep -q '^/src/Raw.java:5: error: \[RawError\]' "${REPORT_DIR}/summary.txt" |
| 52 | + [ "$(< "${REPORT_DIR}/failures")" -eq 2 ] |
65 | 53 | } |
66 | 54 |
|
67 | 55 | @test "Error Prone warnings do not fail the check" { |
68 | | - export MAVEN_EXIT_CODE=0 |
69 | | - cat > "${TEST_TMPDIR}/bin/mvn" <<'EOF' |
70 | | -#!/usr/bin/env bash |
71 | | -rm -rf "${OUTPUT_DIR}" |
72 | | -printf '%s\n' \ |
73 | | - "[WARNING] /src/Legacy.java:[1,1] [JdkObsolete] legacy finding" \ |
74 | | - "/src/Raw.java:4: warning: [RawWarning] raw warning" |
75 | | -exit "${MAVEN_EXIT_CODE}" |
| 56 | + export rc=0 |
| 57 | + cat > "${REPORT_DIR}/output.log" <<'EOF' |
| 58 | +[WARNING] /src/Legacy.java:[1,1] [JdkObsolete] legacy finding |
| 59 | +/src/Raw.java:4: warning: [RawWarning] raw warning |
76 | 60 | EOF |
77 | | - chmod +x "${TEST_TMPDIR}/bin/mvn" |
78 | 61 |
|
79 | | - run hadoop-ozone/dev-support/checks/errorprone.sh |
| 62 | + run hadoop-ozone/dev-support/checks/_errorprone_report.sh |
80 | 63 |
|
81 | 64 | [ "$status" -eq 0 ] |
82 | | - [ "$(wc -l < "${OUTPUT_DIR}/diagnostics.txt")" -eq 2 ] |
83 | | - [ "$(< "${OUTPUT_DIR}/failures")" -eq 0 ] |
84 | | - [ ! -s "${OUTPUT_DIR}/summary.txt" ] |
| 65 | + [ "$(wc -l < "${REPORT_DIR}/diagnostics.txt")" -eq 2 ] |
| 66 | + [ "$(< "${REPORT_DIR}/failures")" -eq 0 ] |
| 67 | + [ ! -s "${REPORT_DIR}/summary.txt" ] |
85 | 68 | } |
86 | 69 |
|
87 | 70 | @test "Error Prone reports an unknown Maven failure" { |
88 | | - cat > "${TEST_TMPDIR}/bin/mvn" <<'EOF' |
89 | | -#!/usr/bin/env bash |
90 | | -rm -rf "${OUTPUT_DIR}" |
91 | | -echo "[ERROR] Failed to execute goal example:example: failed" |
92 | | -exit "${MAVEN_EXIT_CODE}" |
| 71 | + export rc=1 |
| 72 | + cat > "${REPORT_DIR}/output.log" <<'EOF' |
| 73 | +[ERROR] Failed to execute goal example:example: failed |
93 | 74 | EOF |
94 | | - chmod +x "${TEST_TMPDIR}/bin/mvn" |
95 | 75 |
|
96 | | - run hadoop-ozone/dev-support/checks/errorprone.sh |
| 76 | + run hadoop-ozone/dev-support/checks/_errorprone_report.sh |
97 | 77 |
|
98 | 78 | [ "$status" -eq 1 ] |
99 | | - [ ! -s "${OUTPUT_DIR}/diagnostics.txt" ] |
100 | | - [ "$(< "${OUTPUT_DIR}/summary.txt")" = "Unknown failure, check output.log" ] |
101 | | - [ "$(< "${OUTPUT_DIR}/failures")" -eq 1 ] |
| 79 | + [ ! -s "${REPORT_DIR}/diagnostics.txt" ] |
| 80 | + [ "$(< "${REPORT_DIR}/summary.txt")" = "Unknown failure, check output.log" ] |
| 81 | + [ "$(< "${REPORT_DIR}/failures")" -eq 1 ] |
102 | 82 | } |
0 commit comments