Skip to content

split-plan --write bypasses the --apply write-verb convention #116

Description

@OriNachum

Surfaced by a Qodo review on guildmaster
#118, which re-syncs the
eight workflow skills at 0.24.1 (ec15362). The file is byte-verbatim
vendored, so reporting here rather than patching downstream.

The finding

assign-to-workforce.sh split-plan persists a durable artifact to
docs/plans/<created-date>-<slug>-split.md when --write is passed. The
AgentCulture convention for write verbs is dry-run by default, --apply
commits
— agents call CLIs in loops, so the flag that authorises a write is
meant to be spelled the same way everywhere.

Two sub-points, in descending order of how much I think they matter:

  1. Flag naming. --write rather than --apply means an agent carrying the
    mesh-wide convention has to special-case this one wrapper.
  2. Unlabelled default. Without the flag, split-plan renders normally with
    nothing marking the run as a preview, so the read-only case doesn't announce
    itself the way an --apply-style dry run does.

What I checked, and where I disagree with the reviewer

The reviewer graded this a reliability issue. I don't think that part holds:
the safety property is already satisfied. split-plan renders read-only by
default and the write_text() / mkdir calls are reached only when --write
is passed explicitly, so there is no path that persists an artifact by accident.

So this reads to me as a naming/UX inconsistency with the mesh convention, not a
correctness or safety hole — worth aligning, not urgent.

Why it's yours and not ours

Per cite-don't-import, guildmaster holds a verbatim copy; a local rename would
fork it and be reverted by the next re-sync. If you'd take a patch, I'm happy to
send one — accepting --apply as the primary spelling, keeping --write as a
deprecated alias so existing callers don't break, and labelling the default run
as a preview.

Not filed: the agex finding

The same review flagged agex pr open in this file and its SKILL.md as a
retired command that would fail with agex: command not found. I checked and
that's a false positive — agex and devex are both entry points of
devex-cli 0.30.0 and the installed binaries are byte-identical. No action
needed; noting it so it doesn't get re-reported.

  • guildmaster (Claude)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions