Update Node.js version to 24 across actions and package files#7
Open
salmanmkc wants to merge 5 commits into
Open
Update Node.js version to 24 across actions and package files#7salmanmkc wants to merge 5 commits into
salmanmkc wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the project to use Node.js version 24 across various GitHub Actions configurations and package dependencies. The changes include updating action runners, package.json dependencies, and workflow configurations to ensure compatibility with Node.js 24.
Key changes:
- Updates GitHub Actions from
node20tonode24in all action.yml files - Updates Node.js version requirements and type definitions in package.json
- Modifies CI workflows to use Node.js 24
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| wrapper-validation/action.yml | Updates action runner from node20 to node24 |
| setup-gradle/action.yml | Updates action runner from node20 to node24 |
| dependency-submission/action.yml | Updates action runner from node20 to node24 |
| sources/package.json | Updates Node.js engine requirement and @types/node dependency |
| sources/jest.config.js | Conditionally disables Develocity reporter in CI |
| .github/workflows/ci-update-dist.yml | Updates Node.js version in workflow |
| .github/actions/build-dist/action.yml | Updates Node.js version in action |
| sources/test/jest/cache-cleanup.test.ts | Updates test code with dynamic cache directory detection |
Files not reviewed (1)
- sources/package-lock.json: Language not supported
| // Initialize HOME with 2 different Gradle versions | ||
| await runGradleWrapperBuild(projectRoot, 'build') | ||
| await runGradleBuild(projectRoot, 'build') | ||
| await runGradleWrapperBuild(projectRoot, 'build', '3.2') // Use wrapper for all builds, with a different version parameter |
There was a problem hiding this comment.
[nitpick] The comment mentions 'with a different version parameter' but doesn't explain why version '3.2' is chosen or how it differs from the default behavior. Consider clarifying the purpose of this specific version choice.
Suggested change
| await runGradleWrapperBuild(projectRoot, 'build', '3.2') // Use wrapper for all builds, with a different version parameter | |
| // Use wrapper for all builds; here, specify version '3.2' to simulate an older Gradle version in the cache. | |
| // The default (when no version is specified) uses the wrapper's version (e.g., '8.0.2'), so '3.2' ensures the test covers cleanup of unused/older versions. | |
| await runGradleWrapperBuild(projectRoot, 'build', '3.2') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project to use Node.js version 24 across various configurations and dependencies. The changes ensure compatibility with the newer Node.js version by updating associated type definitions and dependencies, as well as specifying the required Node.js version in the project metadata.
I modified gradle and skipped the Develocity reporter during CI, not sure if that's something necessary here since it is giving some auth issues.