Skip to content

Update Node.js version to 24 across actions and package files#7

Open
salmanmkc wants to merge 5 commits into
actions:mainfrom
salmanmkc:node24
Open

Update Node.js version to 24 across actions and package files#7
salmanmkc wants to merge 5 commits into
actions:mainfrom
salmanmkc:node24

Conversation

@salmanmkc
Copy link
Copy Markdown

@salmanmkc salmanmkc commented Jul 30, 2025

This pull request updates the project to use Node.js version 24 across various configurations and dependencies. The changes ensure compatibility with the newer Node.js version by updating associated type definitions and dependencies, as well as specifying the required Node.js version in the project metadata.

I modified gradle and skipped the Develocity reporter during CI, not sure if that's something necessary here since it is giving some auth issues.

@salmanmkc salmanmkc marked this pull request as ready for review August 8, 2025 10:52
Copilot AI review requested due to automatic review settings August 8, 2025 10:52
@salmanmkc salmanmkc requested a review from a team as a code owner August 8, 2025 10:52
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the project to use Node.js version 24 across various GitHub Actions configurations and package dependencies. The changes include updating action runners, package.json dependencies, and workflow configurations to ensure compatibility with Node.js 24.

Key changes:

  • Updates GitHub Actions from node20 to node24 in all action.yml files
  • Updates Node.js version requirements and type definitions in package.json
  • Modifies CI workflows to use Node.js 24

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
wrapper-validation/action.yml Updates action runner from node20 to node24
setup-gradle/action.yml Updates action runner from node20 to node24
dependency-submission/action.yml Updates action runner from node20 to node24
sources/package.json Updates Node.js engine requirement and @types/node dependency
sources/jest.config.js Conditionally disables Develocity reporter in CI
.github/workflows/ci-update-dist.yml Updates Node.js version in workflow
.github/actions/build-dist/action.yml Updates Node.js version in action
sources/test/jest/cache-cleanup.test.ts Updates test code with dynamic cache directory detection
Files not reviewed (1)
  • sources/package-lock.json: Language not supported

// Initialize HOME with 2 different Gradle versions
await runGradleWrapperBuild(projectRoot, 'build')
await runGradleBuild(projectRoot, 'build')
await runGradleWrapperBuild(projectRoot, 'build', '3.2') // Use wrapper for all builds, with a different version parameter
Copy link

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The comment mentions 'with a different version parameter' but doesn't explain why version '3.2' is chosen or how it differs from the default behavior. Consider clarifying the purpose of this specific version choice.

Suggested change
await runGradleWrapperBuild(projectRoot, 'build', '3.2') // Use wrapper for all builds, with a different version parameter
// Use wrapper for all builds; here, specify version '3.2' to simulate an older Gradle version in the cache.
// The default (when no version is specified) uses the wrapper's version (e.g., '8.0.2'), so '3.2' ensures the test covers cleanup of unused/older versions.
await runGradleWrapperBuild(projectRoot, 'build', '3.2')

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants