Tests: Reuse existing fixtures in REST user tests.

Reuse the author and subscriber fixtures in read-only and rejected-request tests in `WP_Test_REST_Users_Controller`, avoiding 13 user creations per class run.

Preserve the requests, assertions, and include-query ordering checks. Keep fresh users for successful updates, deletions, and identity-specific scenarios, and retain per-test post and page fixtures.

Developed in: #14339

Props abcd95.
See #66074.


git-svn-id: https://develop.svn.wordpress.org/trunk@64484 602fd350-edb4-49c9-b593-d223f7449a82

Author: lancewillett

tests/phpunit/tests/rest-api/rest-users-controller.php

@@ -656,8 +656,8 @@ public function test_get_items_offset() {
 	public function test_get_items_include_query() {
 		wp_set_current_user( self::$user );
 
-		$id1 = self::factory()->user->create();
-		$id2 = self::factory()->user->create();
+		$id1 = self::$author;
+		$id2 = self::$subscriber;
 
 		$request = new WP_REST_Request( 'GET', '/wp/v2/users' );
 
@@ -691,8 +691,8 @@ public function test_get_items_include_query() {
 	public function test_get_items_exclude_query() {
 		wp_set_current_user( self::$user );
 
-		$id1 = self::factory()->user->create();
-		$id2 = self::factory()->user->create();
+		$id1 = self::$subscriber;
+		$id2 = self::$author;
 
 		$request = new WP_REST_Request( 'GET', '/wp/v2/users' );
 		$request->set_param( 'per_page', self::$per_page ); // There are >10 users at this point.
@@ -1089,7 +1089,7 @@ public function test_get_items_who_unauthorized_query() {
 	}
 
 	public function test_get_item() {
-		$user_id = self::factory()->user->create();
+		$user_id = self::$subscriber;
 
 		wp_set_current_user( self::$user );
 
@@ -1242,11 +1242,7 @@ public function test_cannot_get_item_author_of_draft() {
 	}
 
 	public function test_get_item_published_author_post() {
-		$author_id = self::factory()->user->create(
-			array(
-				'role' => 'author',
-			)
-		);
+		$author_id = self::$author;
 
 		$post_id = self::factory()->post->create(
 			array(
@@ -1262,11 +1258,7 @@ public function test_get_item_published_author_post() {
 	}
 
 	public function test_get_item_published_author_pages() {
-		$author_id = self::factory()->user->create(
-			array(
-				'role' => 'author',
-			)
-		);
+		$author_id = self::$author;
 
 		wp_set_current_user( 0 );
 
@@ -1286,7 +1278,7 @@ public function test_get_item_published_author_pages() {
 	}
 
 	public function test_get_user_with_edit_context() {
-		$user_id = self::factory()->user->create();
+		$user_id = self::$subscriber;
 
 		$this->allow_user_to_manage_multisite();
 
@@ -1297,11 +1289,7 @@ public function test_get_user_with_edit_context() {
 	}
 
 	public function test_get_item_published_author_wrong_context() {
-		$author_id = self::factory()->user->create(
-			array(
-				'role' => 'author',
-			)
-		);
+		$author_id = self::$author;
 
 		$post_id = self::factory()->post->create(
 			array(
@@ -2183,11 +2171,7 @@ public function test_update_user_invalid_id() {
 	 * @ticket 40263
 	 */
 	public function test_update_item_only_roles_as_editor() {
-		$user_id = self::factory()->user->create(
-			array(
-				'role' => 'author',
-			)
-		);
+		$user_id = self::$author;
 
 		wp_set_current_user( self::$editor );
 
@@ -2595,7 +2579,7 @@ public function test_delete_current_item_no_trash() {
 	}
 
 	public function test_delete_user_without_permission() {
-		$user_id = self::factory()->user->create();
+		$user_id = self::$subscriber;
 
 		$this->allow_user_to_manage_multisite();
 
@@ -3316,7 +3300,7 @@ public function test_get_items_only_fetches_ids_for_head_requests( $method ) {
 	 * @param string $path The path to test.
 	 */
 	public function test_head_request_with_specified_fields_returns_success_response( $path ) {
-		$user_id = self::factory()->user->create();
+		$user_id = self::$subscriber;
 		wp_set_current_user( self::$user );
 
 		$request = new WP_REST_Request( 'HEAD', sprintf( $path, $user_id ) );