Skip to content

Commit 36e7c85

Browse files
committed
Administration: Improve consistency of the disabled buttons styling.
A few buttons had the `cursor: not-allowed;` style applied, which has now been removed. This styling is unnecessary and only introduces inconsistency with other disabled buttons styling. For the removed styles in `colors/_mixins.scss` it is also worth noting that a style related to interaction should not live in a file that contains mixins dedicated to colors. - Removes the `cursor: not-allowed` style from buttons mixins in `colors/_mixins.scss`. - Removes the remaining 3 occurrences for the classic 'Custom HTML' widget, the Theme / Plugin file editors and in the Customizer when reordering menus or widgets. Developed in #14040 Props sainathpoojary, dhruvang21, afercia. Fixes #66251. git-svn-id: https://develop.svn.wordpress.org/trunk@64229 602fd350-edb4-49c9-b593-d223f7449a82
1 parent dee70ee commit 36e7c85

4 files changed

Lines changed: 1 addition & 13 deletions

File tree

‎src/wp-admin/css/colors/_mixins.scss‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
background: tokens.$gray-100;
4141
border-color: transparent;
4242
color: tokens.$gray-600;
43-
cursor: not-allowed;
4443
}
4544

4645
&.active,
@@ -89,7 +88,6 @@
8988
background: transparent;
9089
border-color: tokens.$gray-300;
9190
color: tokens.$gray-600;
92-
cursor: not-allowed;
9391
}
9492
}
9593

@@ -127,6 +125,5 @@
127125
background: transparent;
128126
border-color: tokens.$gray-400;
129127
color: tokens.$gray-600;
130-
cursor: not-allowed;
131128
}
132129
}

‎src/wp-admin/css/common.css‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3625,10 +3625,6 @@ img {
36253625
padding: 0;
36263626
}
36273627

3628-
#template .submit input[type="submit"][disabled] {
3629-
cursor: not-allowed;
3630-
}
3631-
36323628
#templateside {
36333629
float: right;
36343630
width: 16em;

‎src/wp-admin/css/customize-controls.css‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2545,8 +2545,7 @@ body.cheatin p {
25452545
.reordering .add-new-widget,
25462546
.reordering .add-new-menu-item {
25472547
opacity: 0.2;
2548-
pointer-events: none;
2549-
cursor: not-allowed; /* doesn't work in conjunction with pointer-events */
2548+
pointer-events: none; /* Also resets the cursor style. */
25502549
}
25512550

25522551
.add-new-widget::before,

‎src/wp-admin/css/widgets.css‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -796,10 +796,6 @@ ul.CodeMirror-hints {
796796
z-index: 101; /* Due to z-index 100 set on .widget.open */
797797
}
798798

799-
.widget-control-actions .custom-html-widget-save-button.button.validation-blocked {
800-
cursor: not-allowed;
801-
}
802-
803799
/* =Media Queries
804800
-------------------------------------------------------------- */
805801

0 commit comments

Comments
 (0)