From 1367623f5e2b1ebe413e5f1327630d16030e64de Mon Sep 17 00:00:00 2001 From: zachary Date: Wed, 9 Sep 2026 10:11:03 +0100 Subject: [PATCH 1/2] fix: maximum greade --- .../FapReviewBasis/createFapReviewBasisValidationSchema.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/frontend/src/components/questionary/questionaryComponents/FapReviewBasis/createFapReviewBasisValidationSchema.ts b/apps/frontend/src/components/questionary/questionaryComponents/FapReviewBasis/createFapReviewBasisValidationSchema.ts index 3d04eb587b..c9d100d2af 100644 --- a/apps/frontend/src/components/questionary/questionaryComponents/FapReviewBasis/createFapReviewBasisValidationSchema.ts +++ b/apps/frontend/src/components/questionary/questionaryComponents/FapReviewBasis/createFapReviewBasisValidationSchema.ts @@ -31,7 +31,7 @@ export const createFapReviewBasisValidationSchema: QuestionaryComponentDefinitio return isNaN(number) ? true : number >= config.minGrade; }) - .test('max', `Lowest grade is ${config.maxGrade}`, (val) => { + .test('max', `Maximum grade is ${config.maxGrade}`, (val) => { if (val === undefined) return false; const number = parseFloat(val); From 607e7e11a4cf79c7973753d180c51a5fead973ac Mon Sep 17 00:00:00 2001 From: zachary Date: Fri, 11 Sep 2026 08:38:38 +0100 Subject: [PATCH 2/2] change language to minimum --- apps/e2e/cypress/e2e/FAPs.cy.ts | 2 +- .../FapReviewBasis/createFapReviewBasisValidationSchema.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/e2e/cypress/e2e/FAPs.cy.ts b/apps/e2e/cypress/e2e/FAPs.cy.ts index 19274a5473..9c6dbd543f 100644 --- a/apps/e2e/cypress/e2e/FAPs.cy.ts +++ b/apps/e2e/cypress/e2e/FAPs.cy.ts @@ -4148,7 +4148,7 @@ context('Fap meeting components tests', () => { cy.get('[data-cy="save-and-continue-button"]').focus().click(); - cy.contains('Lowest grade is 1'); + cy.contains('Minimum grade is 1'); cy.get('#grade-proposal').click().clear().clear().type('1.001'); diff --git a/apps/frontend/src/components/questionary/questionaryComponents/FapReviewBasis/createFapReviewBasisValidationSchema.ts b/apps/frontend/src/components/questionary/questionaryComponents/FapReviewBasis/createFapReviewBasisValidationSchema.ts index c9d100d2af..dc1673a8ee 100644 --- a/apps/frontend/src/components/questionary/questionaryComponents/FapReviewBasis/createFapReviewBasisValidationSchema.ts +++ b/apps/frontend/src/components/questionary/questionaryComponents/FapReviewBasis/createFapReviewBasisValidationSchema.ts @@ -24,7 +24,7 @@ export const createFapReviewBasisValidationSchema: QuestionaryComponentDefinitio const schema = Yup.object().shape({ comment: commentSchema, grade: Yup.string() - .test('min', `Lowest grade is ${config.minGrade}`, (val) => { + .test('min', `Minimum grade is ${config.minGrade}`, (val) => { if (val === undefined) return false; const number = parseFloat(val);