[#53] Rename view_managed_reference_types to managed_reference_stats_view; fix test whitespace

Author: SkowronskiAndrew

Analyzer.Tests/FileDetectionTests.cs

@@ -512,10 +512,10 @@ public void TryParseMetadata_V22PrefabWithSerializedReference_ReturnsExpectedObj
         for (int i = 0; i < expected.Length; i++)
         {
             var obj = metadata.ObjectList[i];
-            Assert.That(obj.Id,     Is.EqualTo(expected[i].Id),     $"ObjectList[{i}].Id");
+            Assert.That(obj.Id, Is.EqualTo(expected[i].Id), $"ObjectList[{i}].Id");
             Assert.That(obj.TypeId, Is.EqualTo(expected[i].TypeId), $"ObjectList[{i}].TypeId");
             Assert.That(obj.Offset, Is.EqualTo(expected[i].Offset), $"ObjectList[{i}].Offset");
-            Assert.That(obj.Size,   Is.EqualTo(expected[i].Size),   $"ObjectList[{i}].Size");
+            Assert.That(obj.Size, Is.EqualTo(expected[i].Size), $"ObjectList[{i}].Size");
         }
     }
 

Analyzer/Resources/Init.sql

@@ -143,7 +143,7 @@ SELECT
 FROM managed_references m
 INNER JOIN object_view o ON m.object = o.id;
 
-CREATE VIEW view_managed_reference_types AS
+CREATE VIEW managed_reference_stats_view AS
 -- Each distinct [SerializeReference] type: instance count, holding objects and total size.
 SELECT
     class_name,

Documentation/analyze-examples.md

@@ -178,7 +178,7 @@ the outer class name.
 To see every type used, how often, and how many bytes its instances take:
 
 ```
-SELECT * FROM view_managed_reference_types;
+SELECT * FROM managed_reference_stats_view;
 ```
 
 `managed_reference_view` shows the name of the holding object, but not its own C# class. The C#

Documentation/analyzer-schema.md

@@ -69,7 +69,7 @@ AssetBundle and scripting:
 | [`script_object_view`](#script_object_view) | MonoBehaviours and ScriptableObjects with their C# type |
 | [`managed_references`](#managed_references) | `[SerializeReference]` instance held by a MonoBehaviour / ScriptableObject |
 | [`managed_reference_view`](#managed_reference_view) | those instances with the object that holds them |
-| [`view_managed_reference_types`](#view_managed_reference_types) | instance count and total size per `[SerializeReference]` type |
+| [`managed_reference_stats_view`](#managed_reference_stats_view) | instance count and total size per `[SerializeReference]` type |
 
 Type-specific views, each `object_view` plus extra columns:
 
@@ -457,7 +457,7 @@ instance has one row. Null references have no row.
 `managed_references` with the holding MonoBehaviour's `id`, `object_id`, `name`, `archive` and
 `serialized_file` from [`object_view`](#object_view).
 
-## view_managed_reference_types
+## managed_reference_stats_view
 
 One row per distinct `[SerializeReference]` type, with `instances` (row count), `objects` (distinct
 holding MonoBehaviours) and `total_size`, most used first.
@@ -596,7 +596,7 @@ Any schema change - a new or changed table, view or column - must bump the pragm
 | 7 | Unity 6.6 `build_reports` columns and `build_report_content_*` tables ([#107](https://github.com/Unity-Technologies/UnityDataTools/issues/107)); `asset_name` / `asset_extension` columns on `build_report_source_assets` ([#110](https://github.com/Unity-Technologies/UnityDataTools/issues/110)) |
 | 8 | `archives.name` is the path relative to the scanned directory, not the bare file name ([#149](https://github.com/Unity-Technologies/UnityDataTools/issues/149)) |
 | 9 | `content_layout*` tables track the version 3 layout schema of Unity 6.7: loadables keyed by `loadable_index`, `stable_id` / `artifact_index` columns replace `cfid` / `content_hash`, `is_root_asset` records the root position, and the v2-only columns (`asset_path`, `source_lfid`) exist only in databases imported from a version 2 layout ([#131](https://github.com/Unity-Technologies/UnityDataTools/issues/131)) |
-| 10 | Added the `managed_references` table, `managed_reference_view` and `view_managed_reference_types` ([#53](https://github.com/Unity-Technologies/UnityDataTools/issues/53)) |
+| 10 | Added the `managed_references` table, `managed_reference_view` and `managed_reference_stats_view` ([#53](https://github.com/Unity-Technologies/UnityDataTools/issues/53)) |
 
 ## Related documentation
 

UnityDataTool.Tests/AnalyzeV26Tests.cs

@@ -65,7 +65,7 @@ public async Task Analyze_Version26_RecordsEveryManagedReference()
         SQLTestHelper.AssertQueryInt(db, "SELECT COUNT(DISTINCT rid) FROM managed_references", 9, "distinct rids");
 
         SQLTestHelper.AssertQueryInt(db,
-            "SELECT instances FROM view_managed_reference_types WHERE class_name = 'ManagedReferenceTestBehaviour/Shape'",
+            "SELECT instances FROM managed_reference_stats_view WHERE class_name = 'ManagedReferenceTestBehaviour/Shape'",
             4, "Shape instances");
         SQLTestHelper.AssertQueryInt(db,
             "SELECT size FROM managed_references WHERE class_name = 'ManagedReferenceTestBehaviour/TexturedShape'",

UnityDataTool.Tests/BuildReportTests.cs

@@ -80,7 +80,7 @@ public async Task Analyze_BuildReport_ContainsExpected_ObjectInfo(
         // There can be other more obscure objects present, depending on the build,
         // e.g. PluginBuildInfo, AudioBuildInfo, VideoBuildInfo etc.
         var ttlObjCount = SQLTestHelper.QueryInt(db, "SELECT COUNT(*) FROM objects");
-        Assert.That(ttlObjCount, Is.GreaterThanOrEqualTo(1+ packedAssetCount + 1),
+        Assert.That(ttlObjCount, Is.GreaterThanOrEqualTo(1 + packedAssetCount + 1),
             "Unexpected number of objects in BuildReport analysis");
 
         SQLTestHelper.AssertQueryInt(db, "SELECT COUNT(*) FROM archives", 0,

UnityDataTool.Tests/SerializedFileCommandTests.cs

@@ -311,24 +311,24 @@ public async Task ObjectList_NoTypeTree_JsonFormat_OutputsExpectedValues()
 
             // Spot-check a few entries by index
             var first = jsonArray[0];
-            Assert.AreEqual(1,            first.GetProperty("id").GetInt64());
-            Assert.AreEqual(1,            first.GetProperty("typeId").GetInt32());
+            Assert.AreEqual(1, first.GetProperty("id").GetInt64());
+            Assert.AreEqual(1, first.GetProperty("typeId").GetInt32());
             Assert.AreEqual("GameObject", first.GetProperty("typeName").GetString());
-            Assert.AreEqual(576,          first.GetProperty("offset").GetInt64());
-            Assert.AreEqual(63,           first.GetProperty("size").GetInt64());
+            Assert.AreEqual(576, first.GetProperty("offset").GetInt64());
+            Assert.AreEqual(63, first.GetProperty("size").GetInt64());
 
             var third = jsonArray[2];
-            Assert.AreEqual(3,                third.GetProperty("id").GetInt64());
-            Assert.AreEqual(104,              third.GetProperty("typeId").GetInt32());
+            Assert.AreEqual(3, third.GetProperty("id").GetInt64());
+            Assert.AreEqual(104, third.GetProperty("typeId").GetInt32());
             Assert.AreEqual("RenderSettings", third.GetProperty("typeName").GetString());
-            Assert.AreEqual(720,              third.GetProperty("offset").GetInt64());
+            Assert.AreEqual(720, third.GetProperty("offset").GetInt64());
 
             var last = jsonArray[6];
-            Assert.AreEqual(7,               last.GetProperty("id").GetInt64());
-            Assert.AreEqual(114,             last.GetProperty("typeId").GetInt32());
+            Assert.AreEqual(7, last.GetProperty("id").GetInt64());
+            Assert.AreEqual(114, last.GetProperty("typeId").GetInt32());
             Assert.AreEqual("MonoBehaviour", last.GetProperty("typeName").GetString());
-            Assert.AreEqual(1200,            last.GetProperty("offset").GetInt64());
-            Assert.AreEqual(44,              last.GetProperty("size").GetInt64());
+            Assert.AreEqual(1200, last.GetProperty("offset").GetInt64());
+            Assert.AreEqual(44, last.GetProperty("size").GetInt64());
         }
         finally
         {

UnityDataTool.Tests/UnityDataToolAssetBundleTests.cs

@@ -361,7 +361,7 @@ public async Task Analyze_ManagedReferences_DatabaseContainsExpectedContent(
             "AND assembly_name LIKE 'Assembly-CSharp%' AND size = 8",
             1, "Orange instance");
         SQLTestHelper.AssertQueryInt(db,
-            "SELECT COUNT(*) FROM view_managed_reference_types WHERE instances = 1 AND objects = 1", 2,
+            "SELECT COUNT(*) FROM managed_reference_stats_view WHERE instances = 1 AND objects = 1", 2,
             "one row per SerializeReference type");
     }