Skip to content

Proposer::Accept的日志问题 #278

Description

@dyx2025

Proposer::Accept的日志问题

Proposer::Accept日志的m_oProposerState.GetValue().size()被重复打印,应该精简。保留"ValueLen %zu",跟Proposer::Prepare第一行日志对齐。

原代码路径:

void Proposer :: Prepare(const bool bNeedNewBallot)
{
    PLGHead("START Now.InstanceID %lu MyNodeID %lu State.ProposalID %lu State.ValueLen %zu",                                                                                            
            GetInstanceID(), m_poConfig->GetMyNodeID(), m_oProposerState.GetProposalID(),
            m_oProposerState.GetValue().size());

    // .....
}

// ......

void Proposer :: Accept()
{
    // m_oProposerState.GetValue().size()被重复打印
    PLGHead("START ProposalID %lu ValueSize %zu ValueLen %zu", 
            m_oProposerState.GetProposalID(), m_oProposerState.GetValue().size(), m_oProposerState.GetValue().size());
    
    // ......
}      

修改后的代码路径:

void Proposer :: Prepare(const bool bNeedNewBallot)
{
    PLGHead("START Now.InstanceID %lu MyNodeID %lu State.ProposalID %lu State.ValueLen %zu",                                                                                            
            GetInstanceID(), m_poConfig->GetMyNodeID(), m_oProposerState.GetProposalID(),
            m_oProposerState.GetValue().size());

    // .....
}

// ......

void Proposer :: Accept()
{
    /*
    PLGHead("START ProposalID %lu ValueSize %zu ValueLen %zu", 
            m_oProposerState.GetProposalID(), m_oProposerState.GetValue().size(), m_oProposerState.GetValue().size());
    */

    // 修改代码
    PLGHead("START ProposalID %lu ValueLen %zu", 
            m_oProposerState.GetProposalID(), m_oProposerState.GetValue().size());    
    
    // ......
}      

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions