@@ -11,6 +11,17 @@ import (
1111 "github.com/stretchr/testify/assert"
1212)
1313
14+ const (
15+ testToken = "my-token"
16+ testContextURL = "http://bar.com"
17+ urlFlagArg = "--url"
18+ testCACertContext = "cacertdata"
19+ testAPIPath = "/api"
20+ serviceTokenFlagArg = "--service-token"
21+ caCertPathFlagArg = "--ca-cert-path"
22+ caCertBase64DataFlagArg = "--ca-cert-base64-data"
23+ )
24+
1425func setupSaveCmd (t * testing.T ) (* di.MockDeps , * cobra.Command ) {
1526 cli := di .NewMockDeps (t )
1627 cmd := SaveCommand (& cli .Deps )
@@ -29,41 +40,41 @@ func TestSaveContext(t *testing.T) { //nolint:funlen
2940 }{
3041 {
3142 name : "new context" ,
32- args : []string {"--name" , "baz" , "--url" , "http://baz.com" , "--api-token" , "my-token" },
43+ args : []string {nameFlagArg , "baz" , urlFlagArg , "http://baz.com" , "--api-token" , testToken },
3344 expectedContext : config.NamedContext {
3445 Name : "baz" ,
3546 Context : & config.StsContext {
3647 URL : "http://baz.com" ,
37- APIToken : "my-token" ,
38- APIPath : "/api" ,
48+ APIToken : testToken ,
49+ APIPath : testAPIPath ,
3950 },
4051 },
4152 totalContextInConfig : 7 ,
4253 wantErr : false ,
4354 },
4455 {
4556 name : "existing context" ,
46- args : []string {"--name" , "bar" , "--url" , "http://bar.com" , "--service-token" , "my-token" },
57+ args : []string {nameFlagArg , testBar , urlFlagArg , testContextURL , serviceTokenFlagArg , testToken },
4758 expectedContext : config.NamedContext {
48- Name : "bar" ,
59+ Name : testBar ,
4960 Context : & config.StsContext {
50- URL : "http://bar.com" ,
51- ServiceToken : "my-token" ,
52- APIPath : "/api" ,
61+ URL : testContextURL ,
62+ ServiceToken : testToken ,
63+ APIPath : testAPIPath ,
5364 },
5465 },
5566 totalContextInConfig : 6 ,
5667 wantErr : false ,
5768 },
5869 {
5970 name : "existing context ca-cert is set with ca-cert-path" ,
60- args : []string {"--name" , "bar" , "--url" , "http://bar.com" , "--service-token" , "my-token" , "--ca-cert-path" , "testdata/selfSignedCert.crt" },
71+ args : []string {nameFlagArg , testBar , urlFlagArg , testContextURL , serviceTokenFlagArg , testToken , caCertPathFlagArg , "testdata/selfSignedCert.crt" },
6172 expectedContext : config.NamedContext {
62- Name : "bar" ,
73+ Name : testBar ,
6374 Context : & config.StsContext {
64- URL : "http://bar.com" ,
65- ServiceToken : "my-token" ,
66- APIPath : "/api" ,
75+ URL : testContextURL ,
76+ ServiceToken : testToken ,
77+ APIPath : testAPIPath ,
6778 CaCertBase64Data : selfSignedBase64Cert ,
6879 },
6980 },
@@ -72,13 +83,13 @@ func TestSaveContext(t *testing.T) { //nolint:funlen
7283 },
7384 {
7485 name : "new context ca-cert is set with ca-cert-path" ,
75- args : []string {"--name" , "cacertdata" , "--url" , "http://bar.com" , "--service-token" , "my-token" , "--ca-cert-base64-data" , privateCaBase64Cert },
86+ args : []string {nameFlagArg , testCACertContext , urlFlagArg , testContextURL , serviceTokenFlagArg , testToken , caCertBase64DataFlagArg , privateCaBase64Cert },
7687 expectedContext : config.NamedContext {
77- Name : "cacertdata" ,
88+ Name : testCACertContext ,
7889 Context : & config.StsContext {
79- URL : "http://bar.com" ,
80- ServiceToken : "my-token" ,
81- APIPath : "/api" ,
90+ URL : testContextURL ,
91+ ServiceToken : testToken ,
92+ APIPath : testAPIPath ,
8293 CaCertBase64Data : privateCaBase64Cert ,
8394 },
8495 },
@@ -87,13 +98,13 @@ func TestSaveContext(t *testing.T) { //nolint:funlen
8798 },
8899 {
89100 name : "ca-cert-path takes precedence over ca-cert-base64-data" ,
90- args : []string {"--name" , "cacertdata" , "--url" , "http://bar.com" , "--service-token" , "my-token" , "--ca-cert-path" , "testdata/selfSignedCert.crt" , "--ca-cert-base64-data" , privateCaBase64Cert },
101+ args : []string {nameFlagArg , testCACertContext , urlFlagArg , testContextURL , serviceTokenFlagArg , testToken , caCertPathFlagArg , "testdata/selfSignedCert.crt" , caCertBase64DataFlagArg , privateCaBase64Cert },
91102 expectedContext : config.NamedContext {
92- Name : "cacertdata" ,
103+ Name : testCACertContext ,
93104 Context : & config.StsContext {
94- URL : "http://bar.com" ,
95- ServiceToken : "my-token" ,
96- APIPath : "/api" ,
105+ URL : testContextURL ,
106+ ServiceToken : testToken ,
107+ APIPath : testAPIPath ,
97108 CaCertBase64Data : selfSignedBase64Cert ,
98109 },
99110 },
@@ -102,13 +113,13 @@ func TestSaveContext(t *testing.T) { //nolint:funlen
102113 },
103114 {
104115 name : "ca-cert ignored if skip-ssl is set" ,
105- args : []string {"--name" , "bar" , "--url" , "http://bar.com" , "--service-token" , "my-token" , "--skip-ssl" , "--ca-cert-path" , "/path/to/ca.crt" , "--ca-cert-base64-data" , "base64-data" },
116+ args : []string {nameFlagArg , testBar , urlFlagArg , testContextURL , serviceTokenFlagArg , testToken , "--skip-ssl" , caCertPathFlagArg , "/path/to/ca.crt" , caCertBase64DataFlagArg , "base64-data" },
106117 expectedContext : config.NamedContext {
107- Name : "bar" ,
118+ Name : testBar ,
108119 Context : & config.StsContext {
109- URL : "http://bar.com" ,
110- ServiceToken : "my-token" ,
111- APIPath : "/api" ,
120+ URL : testContextURL ,
121+ ServiceToken : testToken ,
122+ APIPath : testAPIPath ,
112123 SkipSSL : true ,
113124 CaCertBase64Data : "" ,
114125 CaCertPath : "" ,
@@ -119,14 +130,14 @@ func TestSaveContext(t *testing.T) { //nolint:funlen
119130 },
120131 {
121132 name : "no save on missing tokens" ,
122- args : []string {"--name" , "bar" , "--url" , "http://my-bar.com" },
133+ args : []string {nameFlagArg , testBar , urlFlagArg , "http://my-bar.com" },
123134 expectedContext : config.NamedContext {},
124135 wantErr : true ,
125136 errorMessage : "one of the required flags {api-token | service-token} not set" ,
126137 },
127138 {
128139 name : "ca-cert-path is not found" ,
129- args : []string {"--name" , "bar" , "--url" , "http://my-bar.com" , "--service-token" , "my-token" , "--ca-cert-path" , "/path/to/ca.crt" },
140+ args : []string {nameFlagArg , testBar , urlFlagArg , "http://my-bar.com" , serviceTokenFlagArg , testToken , caCertPathFlagArg , "/path/to/ca.crt" },
130141 expectedContext : config.NamedContext {},
131142 wantErr : true ,
132143 errorMessage : "no such file or directory" ,
0 commit comments