Skip to content

Commit 5b93213

Browse files
Merge pull request #165 from StackVista/sts-559
STS-559: Send a default unlock fail rather than empty
2 parents 42d67de + 9364d11 commit 5b93213

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

‎cmd/stackpack/stackpack_upgrade.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ sts stackpack upgrade --name kubernetes --wait`,
4040
common.AddRequiredNameFlagVar(cmd, &args.TypeName, "Name of the StackPack")
4141
pflags.EnumVar(cmd.Flags(), &args.UnlockedStrategy,
4242
UnlockedStrategyFlag,
43-
"",
43+
"fail",
4444
UnlockedStrategyChoices,
4545
"Strategy use to upgrade StackPack instance"+
4646
fmt.Sprintf(" (must be { %s })", strings.Join(UnlockedStrategyChoices, " | ")),

‎cmd/stackpack/stackpack_upgrade_test.go‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,19 @@ func TestStackpackUpgradePrintToJson(t *testing.T) {
7070
assert.Equal(t, expectedJsonCalls, *cli.MockPrinter.PrintJsonCalls)
7171
}
7272

73+
func TestStackpackUpgradeDefaultsUnlockedStrategy(t *testing.T) {
74+
cli, cmd := setupStackPackUpgradeCmd(t)
75+
di.ExecuteCommandWithContextUnsafe(&cli.Deps, cmd, "upgrade", "--name", "zabbix")
76+
77+
defaultStrategy := "fail"
78+
assert.Equal(t,
79+
[]stackstate_api.UpgradeStackPackCall{{
80+
PstackPackName: "zabbix",
81+
Punlocked: &defaultStrategy,
82+
}},
83+
*cli.MockClient.ApiMocks.StackpackApi.UpgradeStackPackCalls)
84+
}
85+
7386
func TestStackpackUpgradeHasWaitFlags(t *testing.T) {
7487
cli := di.NewMockDeps(t)
7588
cmd := StackpackUpgradeCommand(&cli.Deps)

0 commit comments

Comments
 (0)