Skip to content

protonvpn-np@5.1.9: Update URLs - #662

Merged
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
STSMHQ:patch-1
Nov 15, 2026
Merged

z-Fng merged 1 commit into
ScoopInstaller:masterfrom
STSMHQ:patch-1

Conversation

@STSMHQ

@STSMHQ STSMHQ commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Fixes #661


@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the 64-bit download link to use the new download domain.

Walkthrough

The 64-bit ProtonVPN installer URL and autoupdate template now use vpn.protondownload.com. Their version-specific paths remain unchanged.

Changes

ProtonVPN download URLs

Layer / File(s) Summary
Update 64-bit download URLs
bucket/protonvpn-np.json
The 64-bit installer URL and autoupdate template use vpn.protondownload.com instead of download.protonvpn.net. The version-specific paths remain unchanged.

Severity of issue fixed: Medium

Merge Risk: Minimal · up to df293

This updates the ProtonVPN 64-bit download host to fix the failed download reported in the linked issue. No concrete risk was found, so the change looks ready to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description check Passed The description links the PR to issue #661 with 'Fixes #661', which satisfies the template's required issue reference. The contributing guide checkbox is marked as read. The template's required 'Close…
Linked Issues check Passed The only directly linked issue, #661, is closed. Per the assessment rules, it supplies background only, so no active coding requirements apply. The PR changes the 64-bit download URL in bucket/protonv…
Out of Scope Changes check Passed The reviewed changes are limited to bucket/protonvpn-np.json, with +2/-2 lines. They change the host in the 64-bit download URL and in the autoupdate template from download.protonvpn.net to vpn.proton…
Title check Passed The title names the package and version (protonvpn-np@5.1.9) and says the change is a URL update. The diff changes the 64-bit download URL and its autoupdate template from download.protonvpn.net to vp…
Full details: Description check

Explanation

The description links the PR to issue #661 with 'Fixes #661', which satisfies the template's required issue reference. The contributing guide checkbox is marked as read. The template's required 'Closes #XXXX' or 'Relates to #XXXX' line is present in the form 'Fixes #661', so the template's intent is met. The description gives no summary of the change itself, so it is brief. The missing summary is a non-critical gap because the title and linked issue explain the change.

Full details: Linked Issues check

Explanation

The only directly linked issue, #661, is closed. Per the assessment rules, it supplies background only, so no active coding requirements apply. The PR changes the 64-bit download URL in bucket/protonvpn-np.json, which addresses the failed download reported in #661. No coding requirement is left unmet.

Full details: Out of Scope Changes check

Explanation

The reviewed changes are limited to bucket/protonvpn-np.json, with +2/-2 lines. They change the host in the 64-bit download URL and in the autoupdate template from download.protonvpn.net to vpn.protondownload.com. The version-specific path is unchanged. This directly matches the package and download URL named in #661, so the changes are connected to the linked issue and are not out of scope.

Full details: Title check

Explanation

The title names the package and version (protonvpn-np@5.1.9) and says the change is a URL update. The diff changes the 64-bit download URL and its autoupdate template from download.protonvpn.net to vpn.protondownload.com, so the title matches the main change. It does not name the new host, but it covers the change at the right level.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d4e371c3-4b49-4138-b327-ba988b14294f
Commits

Reviewing files that changed from the base of the PR and between 628ccbe and df29369.

Files selected for processing: 1

  • bucket/protonvpn-np.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@STSMHQ

STSMHQ commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

protonvpn-np

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@STSMHQ

STSMHQ commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

@z-Fng Can we have this merged, please?

@z-Fng z-Fng changed the title protonvpn-np@5.1.9: update url protonvpn-np@5.1.9: Update URLs Nov 15, 2026

@z-Fng z-Fng left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

https://vpn.protondownload.com/download/ProtonVPN_v5.1.9_x64.exe

Verified that this is an official domain based on https://protonvpn.com/download/windows-releases.json.

                {
                    "Version": "5.1.9",
                    "File": {
                        "Url": "https://vpn.protondownload.com/download/ProtonVPN_v5.1.9_x64.exe",
                        "SHA256CheckSum": "8454eba06a37c0a636ec8dcfe6a7a823a68a78ee8fe2eeda2d651cd5cd6c3d70",
                        "SHA512CheckSum": "342f8e8a9861c77e5b4d0a3eb8f6f3fad5b962492944effab57c8616e269cb57a02c9cc4acf80519323c769db11284509064b0fab919c7c908f36dc121227c9a",
                        "Arguments": "/silent"
                    },
                    ...
                },

@z-Fng
z-Fng merged commit dbc81f4 into ScoopInstaller:master Nov 15, 2026
6 checks passed
@STSMHQ
STSMHQ deleted the patch-1 branch November 15, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

protonvpn-np@5.1.9: download failed

2 participants