Skip to content

Commit a7dfd78

Browse files
authored
Merge pull request #58 from Quantus-Network/beast/subtle-ux-improvement
feat: subtle ux improvement
2 parents ec933ec + f543905 commit a7dfd78

6 files changed

Lines changed: 12 additions & 26 deletions

File tree

‎src/api/unified-transactions.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ const UNIFIED_TX_FIELDS = `
3737
}
3838
timestamp
3939
amount
40-
fee
4140
status
4241
detail_id
4342
from {

‎src/components/common/table-columns/UNIFIED_LIST_TRANSACTION_COLUMNS.tsx‎

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ export const UNIFIED_LIST_TRANSACTION_COLUMNS = [
8383
address={id}
8484
href={`${RESOURCES.accounts}/${id}`}
8585
text={formatTxAddress(id)}
86-
className="font-mono text-muted-text"
8786
/>
8887
);
8988
},
@@ -100,7 +99,6 @@ export const UNIFIED_LIST_TRANSACTION_COLUMNS = [
10099
address={id}
101100
href={`${RESOURCES.accounts}/${id}`}
102101
text={formatTxAddress(id)}
103-
className="font-mono text-muted-text"
104102
/>
105103
);
106104
},
@@ -117,21 +115,6 @@ export const UNIFIED_LIST_TRANSACTION_COLUMNS = [
117115
},
118116
enableSorting: true
119117
}),
120-
columnHelper.accessor('fee', {
121-
id: 'fee',
122-
header: 'Fee',
123-
cell: (props) => {
124-
const value = props.getValue();
125-
if (value == null)
126-
return <span className="font-mono text-muted-text">—</span>;
127-
return (
128-
<span className="numeric text-muted-text">
129-
{formatMonetaryValue(value, 5)}
130-
</span>
131-
);
132-
},
133-
enableSorting: true
134-
}),
135118
columnHelper.accessor('status', {
136119
id: 'status',
137120
header: 'Status',

‎src/components/features/multisig-created-details/multisig-created-fields.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ const getSharedMultisigConfigurationFields = (): MultisigCreatedField[] => [
4848
<AccountAddressCell
4949
address={creatorId}
5050
href={`${RESOURCES.accounts}/${creatorId}`}
51+
truncate={false}
5152
/>
5253
) : (
5354
<EmptyValue />
@@ -67,6 +68,7 @@ const getSharedMultisigConfigurationFields = (): MultisigCreatedField[] => [
6768
key={signer}
6869
address={signer}
6970
href={`${RESOURCES.accounts}/${signer}`}
71+
truncate={false}
7072
/>
7173
))}
7274
</div>

‎src/components/features/multisig-details/MultisigDetailDataTabs.tsx‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,16 @@ export const MultisigDetailDataTabs: React.FC<Props> = ({ walletId }) => {
2424

2525
const handleTabChange = (value: string) => {
2626
const nextTab = value as MultisigDetailTab;
27-
void setPage(1);
28-
void setOrderBy(null);
29-
void navigate({
27+
setPage(1);
28+
setOrderBy(null);
29+
navigate({
3030
to: '/multisig/$id',
3131
params: { id },
3232
search: {
3333
tab: nextTab,
3434
status: nextTab === 'proposals' ? status : 'all'
35-
}
35+
},
36+
resetScroll: false
3637
});
3738
};
3839

‎src/components/features/multisig-details/MultisigDetailStatusFilter.tsx‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,15 @@ export const MultisigDetailStatusFilter: React.FC = () => {
1919
});
2020

2121
const handleStatusChange = (nextStatus: MultisigProposalStatusFilter) => {
22-
void setPage(1);
23-
void navigate({
22+
setPage(1);
23+
navigate({
2424
to: '/multisig/$id',
2525
params: { id },
2626
search: {
2727
tab: tab ?? 'proposals',
2828
status: nextStatus
29-
}
29+
},
30+
resetScroll: false
3031
});
3132
};
3233

‎src/components/features/multisig-details/index.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import useApiClient from '@/api';
55
import { ContentContainer } from '@/components/ui/content-container';
66
import { SectionContainer } from '@/components/ui/section-container';
77

8-
import { MultisigDetailDataTabs } from './MultisigDetailDataTabs';
98
import { MultisigInformation } from './multisig-information/MultisigInformation';
9+
import { MultisigDetailDataTabs } from './MultisigDetailDataTabs';
1010

1111
interface Props {
1212
id: string;

0 commit comments

Comments
 (0)