Repository navigation
Commit 5559872
committed
owen-cli-release: fix doc drift, close two script-injection nitpicks
CodeRabbit review:
- docs/notes/owen-cli-release.md quoted the publish gate as just
`startsWith(github.ref, 'refs/tags/owen-cli-v')`, dropping the
`github.event_name == 'push'` half the workflow's own comment explains
is required to block a `workflow_dispatch --ref owen-cli-vX` bypass --
the exact scenario the doc's next sentence claimed was already
impossible. Quoted the real condition in full.
- `${{ steps.version.outputs.version }}` (grep'd from the csproj, which
this workflow now also builds on pull_request) and
`${{ needs.build-test-pack.outputs.version }}` were both inlined
directly into run: scripts at five sites -- the same
expression-into-shell-text pattern zizmor flags elsewhere in this repo.
Both now flow through env: (a job-level OWEN_CLI_VERSION for
smoke-test's four sites, a step-level CSPROJ_VERSION for the
tag/version-match assertion) instead of raw interpolation.
Not implemented: CodeRabbit's NuGet Trusted Publishing (OIDC) suggestion
for the publish step. Real publication is already blocked on the license
and Environment decisions the docs already flag as the repository owner's
call, not this session's; swapping the auth mechanism before either of
those is resolved is the same category of decision, not a code fix.
Re-verified locally end-to-end after the env: refactor: pack, isolated-feed
install, `owen --version`, and the full uninstall/reinstall cycle all still
pass with the version flowing through the environment instead of inline
interpolation.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SSXTDuh1ZHdQc4QqmYwshw1 parent 76cdf62 commit 5559872
2 files changed
Lines changed: 26 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
93 | 100 | | |
94 | 101 | | |
95 | | - | |
| 102 | + | |
96 | 103 | | |
97 | 104 | | |
98 | 105 | | |
| |||
138 | 145 | | |
139 | 146 | | |
140 | 147 | | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
141 | 154 | | |
142 | 155 | | |
143 | 156 | | |
| |||
179 | 192 | | |
180 | 193 | | |
181 | 194 | | |
182 | | - | |
| 195 | + | |
183 | 196 | | |
184 | 197 | | |
185 | 198 | | |
| |||
197 | 210 | | |
198 | 211 | | |
199 | 212 | | |
200 | | - | |
201 | | - | |
| 213 | + | |
| 214 | + | |
202 | 215 | | |
203 | 216 | | |
204 | 217 | | |
| |||
243 | 256 | | |
244 | 257 | | |
245 | 258 | | |
246 | | - | |
| 259 | + | |
247 | 260 | | |
248 | | - | |
| 261 | + | |
249 | 262 | | |
250 | 263 | | |
251 | 264 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
134 | | - | |
135 | | - | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
136 | 140 | | |
137 | 141 | | |
138 | 142 | | |
| |||
0 commit comments