Skip to content

[Bug]: patina_adv_logger: Init the Hardware Port if Not Already Initialized #1599

Description

@os-d

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

patina_adv_logger will not initialize the hardware port because it assumes previous phases have already done so. However, this is not guaranteed. The in log field that describes whether the hardware port is initialized assumes a single serial port is used for logging for all consumers of the buffer. However, this is not the case. As such, the field cannot be relied upon, patina_adv_logger can't know that its serial port has been initialized.

Expected Behavior

patina_adv_logger should initialize the hardware port on initialization. Note, this should be considered a breaking change because Patina has not been doing this before and platform serial code may not be anticipating multiple initializes, though this does occur in edk2 as well.

Steps To Reproduce

n/a.

Build Environment

- OS(s):
- Targets Impacted:

Version Information

top of tree

Urgency

Low

Are you going to fix this?

Someone else needs to fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    state:needs-ownerNeeds an issue owner to be assignedstate:needs-triageNeeds to triaged to determine next stepstype:bugSomething isn't workingurgency:lowLittle to no impact

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    Status
    Backlog

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions