Skip to content

Commit 8cf5d60

Browse files
Say the same thing about model stores everywhere
The published pages still described the arrangement this series replaced, and the two front ends reassured users differently about the same action. engine-lifecycle.mdx and architecture.mdx still placed llama.cpp's cache "beside PAIR's managed install", the location that was lost when app data was purged. terminal-interface.mdx described the TUI reset without the engine removal it now performs or the models it keeps. The desktop architecture note and the root README listed only two of the three model stores, and the README promised a Linux purge removes "any engine PAIR installed" when one placed in the user's home by a vendor installer survives it. The wipe scripts' "never add" comments omitted ~/.llamacpp. That comment is what a future editor reads before adding a wipe target, so leaving the newest store out of it is the omission most likely to cost someone their models. MANIFEST.md: models_dir was missing from the shared-defaults row, the Validation section did not list the rejections this series added, and the {models_dir} row overstated where the placeholder resolves -- install provides only {install_dir}, and naming the store in uninstall.remove is rejected at load. The desktop uninstall confirmation now matches the TUI's, which says downloaded models are kept. Asking "are you sure?" while the other client explains the consequence left the more cautious wording on the quieter surface. Signed-off-by: Terve <ntervalon@nvidia.com>
1 parent 3031144 commit 8cf5d60

10 files changed

Lines changed: 47 additions & 25 deletions

File tree

‎README.md‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,9 @@ your data. Decline and it stays; accept and it is removed.
179179
**Linux.** `sudo apt remove nvpair` uninstalls the application and keeps your
180180
data. Use `sudo apt purge nvpair` to remove the data as well. Run
181181
`dpkg -l | grep -i pair` first if you need to confirm the installed package name.
182+
A purge removes the engines PAIR installed under its own data directory, but not
183+
one a vendor installer placed in your home, as LM Studio does — uninstall that
184+
engine from PAIR before removing the package, or use its own uninstaller.
182185

183186
**macOS.** Run the uninstaller that ships inside the app bundle. It stops PAIR,
184187
removes its firewall rules, unregisters its privileged helper, and then removes
@@ -195,9 +198,10 @@ leaves the privileged helper registered, so use the uninstaller.
195198

196199
Your data means settings, logs, cluster identity and certificates, and any engine
197200
PAIR installed for you. **Model weights are not touched** — they live in the
198-
engine's own storage, such as `~/.ollama`, so removing PAIR does not delete the
199-
models you downloaded. Delete those through the engine, or by removing its
200-
directory.
201+
engine's own storage (`~/.ollama`, `~/.llamacpp`, `~/.lmstudio/models`), so
202+
removing PAIR does not delete the models you downloaded. Delete those through the
203+
engine, or by removing its directory. An engine you installed yourself is also
204+
left alone.
201205

202206
**To clear your data without uninstalling,** use **Settings → Service → Reset app
203207
data**. It removes the same set — settings, logs, cluster identity and

‎desktop/docs/architecture.md‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -408,8 +408,11 @@ deletes finish. Unpackaged (`electron-vite dev`) builds omit relaunch and the UI
408408
tells the developer to run `npm start` again — quitting Electron tears down the Vite
409409
renderer server, so auto-relaunch would come up with nothing to load.
410410

411-
Third-party model libraries (`~/.ollama`, `~/.lmstudio`) and the application install
412-
tree are never removed.
411+
The engines' model stores (`~/.ollama`, `~/.llamacpp`, `~/.lmstudio/models`) and
412+
the application install tree are never removed. The reset does uninstall the
413+
engines PAIR installed, through `engine:uninstall-managed` while the broker is
414+
still running, so an engine a vendor installer placed in the user's home is
415+
removed too rather than only those inside the app data folder.
413416

414417
## Sources of truth
415418

‎desktop/docs/services-parity.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,8 @@ fallback; hardware acceptance is still required to confirm acceleration.
169169
The facade is in the default broker and TUI set: local OpenAI-compatible clients
170170
use the broker-reported listener (normally `8080`) while the managed router runs
171171
on `8081`. Desktop and TUI expose install, lifecycle, download progress,
172-
inventory, load/unload, endpoint, routed state, and inference-demo workflows;
173-
Desktop also exposes model deletion.
172+
inventory, load/unload, endpoint, routed state, and inference-demo workflows.
173+
Both also expose model deletion.
174174
Desktop browsing populates a six-hour cache from the 50 most-downloaded GGUF
175175
repositories for each approved publisher and can explicitly search up to 50
176176
public Hugging Face matches. Results are limited to pull-ready `Q4_K_M` IDs.

‎desktop/src/ui/components/BackendRow/BackendRow.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ export function BackendRow({
232232
open={confirmUninstall}
233233
onOpenChange={setConfirmUninstall}
234234
title="Uninstall"
235-
message={`Are you sure you want to uninstall ${backend.displayName}?`}
235+
message={`Uninstall ${backend.displayName}? Your downloaded models are kept.`}
236236
confirmLabel="Uninstall"
237237
confirmColor="danger"
238238
onConfirm={handleUninstall}

‎docs/architecture.mdx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,8 @@ present downloads nothing and reports it as installed.
468468
llama.cpp uses PAIR's managed router rather than an arbitrary existing server.
469469
Its readiness check requires the listener to identify itself as a router, so a
470470
single-model `llama-server` on the configured port is rejected instead of
471-
adopted. Its model cache is separate and survives uninstall or reinstall.
471+
adopted. Its models live in `~/.llamacpp`, outside PAIR's own data directory, so
472+
they survive uninstalling the engine, resetting PAIR's data, and removing PAIR.
472473

473474
Starting is similarly deferential. If something is already serving the engine's
474475
port, PAIR **adopts** that instance instead of spawning a second copy, and reports

‎docs/engine-lifecycle.mdx‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -127,11 +127,15 @@ Both actions apply only to an engine PAIR installed:
127127
no longer want PAIR to own that engine on the machine.
128128

129129
Uninstalling an engine does **not** remove its models. Downloaded model files stay
130-
on disk, in the engine's own storage such as `~/.ollama`, so uninstalling and
131-
reinstalling does not cost you re-downloading them. To reclaim that space, delete
132-
the models through the engine, or remove its data directory yourself. llama.cpp
133-
uses a persistent cache beside PAIR's managed install; use **Delete** to remove
134-
individual entries without removing the engine.
130+
on disk in the engine's own storage — `~/.ollama`, `~/.llamacpp`, or
131+
`~/.lmstudio/models` — so uninstalling and reinstalling does not cost you
132+
re-downloading them. The same is true of removing PAIR itself, or of resetting
133+
its data: those remove the engines PAIR installed, never your models. To reclaim
134+
that space, use **Delete** on individual models, or remove the engine's storage
135+
directory yourself.
136+
137+
PAIR also leaves alone any engine you installed yourself. **Uninstall** acts only
138+
on a copy PAIR installed; remove the others with the engine's own uninstaller.
135139

136140
Port changes for an NVPAIR-installed engine also live in **Engine settings**.
137141
Prefer the controls in PAIR over editing the engine's own config when PAIR is

‎docs/terminal-interface.mdx‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -473,9 +473,12 @@ the **Nodes** tab. Refer to
473473
for how PAIR arranges ports.
474474

475475
**Reset all data and quit** deletes this machine's settings, cluster identity,
476-
and pairing, then exits. It asks for confirmation first, and cannot be undone.
477-
The services are stopped before anything is deleted, so nothing rewrites the
478-
files on the way out. You will need to pair again afterwards.
476+
and pairing, and uninstalls the engines PAIR installed, then exits. It asks for
477+
confirmation first, and cannot be undone. Your downloaded models are kept, and
478+
so is any engine you installed yourself. The engines are removed while the
479+
services are still running, and the services are then stopped before the files
480+
are deleted, so nothing rewrites them on the way out. You will need to pair
481+
again afterwards.
479482

480483
## What the Terminal Interface Cannot Do
481484

‎scripts/wipe-app-data.ps1‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@
2323
# - desktop/scripts/build/{installer.nsh,linux/after-remove.sh,macos/uninstall.sh}
2424
# - scripts/wipe-app-data.sh (Unix twin — update both in the same change)
2525
#
26-
# Explicit exclusions (never add): %USERPROFILE%\.ollama, .lmstudio, external
27-
# engine installs, and the application install tree (Program Files\PAIR).
26+
# Explicit exclusions (never add): %USERPROFILE%\.ollama, %USERPROFILE%\.llamacpp,
27+
# %USERPROFILE%\.lmstudio, external engine installs, and the application install
28+
# tree (Program Files\PAIR). Those three are the engines' model stores; each
29+
# engine declares its own as models_dir, and nothing PAIR removes may delete one.
2830
# ---------------------------------------------------------------------------
2931

3032
[CmdletBinding()]

‎scripts/wipe-app-data.sh‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,10 @@
2424
# - desktop/scripts/build/{installer.nsh,linux/after-remove.sh,macos/uninstall.sh}
2525
# - scripts/wipe-app-data.ps1 (Windows twin — update both in the same change)
2626
#
27-
# Explicit exclusions (never add): ~/.ollama, ~/.lmstudio, external engine
28-
# installs, and the application install tree (Program Files / /opt/PAIR /
29-
# the macOS app bundle).
27+
# Explicit exclusions (never add): ~/.ollama, ~/.llamacpp, ~/.lmstudio, external
28+
# engine installs, and the application install tree (Program Files / /opt/PAIR /
29+
# the macOS app bundle). Those three are the engines' model stores; each engine
30+
# declares its own as models_dir, and nothing PAIR removes may delete one.
3031
# ---------------------------------------------------------------------------
3132
set -uo pipefail
3233

‎services/nvpair-engine-manager/MANIFEST.md‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ and recovery. Editing `args`/`start` directly remains trusted manifest authoring
122122
| `manifest_version` | int | yes | Must be `1`. A higher value is rejected (asks for behavior this binary lacks). Unknown optional fields within a supported version are ignored, so the schema can grow additively. |
123123
| `platforms` | object | yes | Map of `"<goos>/<goarch>"` → platform block (e.g. `"windows/amd64"`, `"darwin/arm64"`, `"linux/amd64"`). At least one entry. The runner selects the block matching the host. |
124124
| `actions` | object | no | Map of action name → action (see below). |
125-
| `detect` / `install` / `uninstall` / `runtime` | — | no | Optional **shared defaults** inherited by every platform (see below). |
125+
| `detect` / `install` / `uninstall` / `models_dir` / `runtime` | — | no | Optional **shared defaults** inherited by every platform (see below). |
126126

127127
**Shared defaults & per-platform overrides.** The platform-level fields `detect`, `install`, `uninstall`, `models_dir`, and `runtime` may also be given once at the top level as shared defaults; each `platforms` entry is then merged onto them. Nested objects (e.g. `runtime`, `runtime.env`) merge key-by-key with the platform value winning, while arrays and scalars are replaced wholesale. So a runtime that's identical across platforms except `cli` is declared once at the top level, and each platform sets only `"runtime": { "cli": "…" }`. Omitting a key inherits the default; setting it (even to a zero value like `"port": 0`) overrides it. A manifest that fully specifies each platform with no top-level defaults behaves exactly as before.
128128

@@ -376,7 +376,7 @@ validation at load:
376376
| `{download}` | Path of the verified download | `install.run` |
377377
| `{download_<name>}` | Path of a verified member of `install.artifacts` | `install.run` |
378378
| `{install_dir}` | Per-engine user-scoped install dir | `detect`, `install`, runtime |
379-
| `{models_dir}` | The platform's `models_dir`, expanded | runtime args/env, `uninstall.remove`, action `remove_path` |
379+
| `{models_dir}` | The platform's `models_dir`, expanded | `detect`, runtime args/env, `uninstall.run`, actions. **Not** `install`, which resolves only `{install_dir}` and the download paths — and not `uninstall.remove`, where naming the store is rejected at load. Unset when the platform declares no store, so a template referencing it then fails to resolve rather than silently becoming a path under `/` |
380380

381381
A `cmd` action additionally templates the action's own `params` as
382382
placeholders (e.g. `{model}`), resolved at call time. HTTP actions send
@@ -393,7 +393,11 @@ field is missing, `manifest_version` is unsupported, a platform key isn't
393393
nor nonempty `artifacts`, `fetch` or nonempty `artifacts` is present without
394394
nonempty `install.run`, `install.script` is combined with
395395
`fetch`/`artifacts`/`run`, `install.mode` or
396-
`runtime.mode` is invalid, an action sets none or more than one of
396+
`runtime.mode` is invalid, `models_dir` is a template rather than a literal
397+
path, an `uninstall` block sets neither `run` nor `remove`, `uninstall.remove`
398+
is present without a `models_dir` to preserve, an `uninstall.remove` target is
399+
the model store or inside it (whether spelled literally or as `{models_dir}`),
400+
an action sets none or more than one of
397401
`http`/`cmd`/`remove_path`, a `remove_path` action omits `root` or
398402
`path`, `http.params_in` is not `body` or `query`, a `result` is set without
399403
both `array` and `field` (or a

0 commit comments

Comments
 (0)