Skip to content

Commit a9a635a

Browse files
authored
fix(release): qualify prerelease tag pushes (#4335)
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
1 parent cf6ec17 commit a9a635a

4 files changed

Lines changed: 22 additions & 2 deletions

File tree

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
name: release-openshell
3+
description: Pick the latest qualified OpenShell prerelease and tag its commit as stable. Create and qualify a prerelease first when none exists.
4+
metadata:
5+
internal: true
6+
---
7+
8+
# Release OpenShell
9+
10+
For the intended release version, pick the latest prerelease whose Release
11+
Qualification job passed. Confirm that its qualification summary matches the
12+
tag and commit. Present the candidate and changes since the previous stable
13+
release to the maintainer; once approved, tag that exact commit as `vX.Y.Z`.
14+
15+
If no prerelease exists, agree on the version and source commit, then create and
16+
push `vX.Y.Z-pre.1`. Wait for qualification to pass before promoting it.
17+
18+
Both prerelease and stable tag pushes start Release Tag. Release Auto-Tag uses
19+
an explicit dispatch because its `GITHUB_TOKEN` pushes do not trigger workflows.
20+
Watch the stable release run and report its result.

‎.github/workflows/release-tag.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ on:
44
push:
55
tags:
66
- "v*.*.*"
7-
- "!v*.*.*-pre.*"
87
workflow_dispatch:
98
inputs:
109
tag:

‎CI.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,7 @@ These workflows run after merge to publish dev/tagged artifacts and verify them.
548548
| File | Role |
549549
|---|---|
550550
| `.github/workflows/release-dev.yml` | Publishes the rolling `dev` build on every push to `main`. Builds gateway, sandbox, and supervisor images and binaries, packages, wheels, and pushes the Helm chart as `oci://ghcr.io/nvidia/openshell/helm-chart:0.0.0-dev` (plus an immutable `0.0.0-dev.<sha>` pin). Also dispatchable manually. |
551-
| `.github/workflows/release-tag.yml` | Publishes tagged stable releases and manually dispatched pre-releases. Its automatic tag trigger excludes `-pre.*`. Both require the currently implemented qualification profile to pass before publication; the summary identifies the remaining RFC 0014 coverage. Failed candidates retain build artifacts and evidence in Actions storage. Source-SHA OCI images remain available as qualification inputs. |
551+
| `.github/workflows/release-tag.yml` | Publishes stable releases and pre-releases on tag pushes or manual dispatch. Release Auto-Tag dispatches it explicitly because its `GITHUB_TOKEN` pushes do not trigger workflows. Both require the currently implemented qualification profile to pass before publication; the summary identifies the remaining RFC 0014 coverage. Failed candidates retain build artifacts and evidence in Actions storage. Source-SHA OCI images remain available as qualification inputs. |
552552
| `.github/workflows/snap-package.yml` | Builds snap and component artifacts for Release Dev and Release Tag without Store credentials or publication. |
553553
| `.github/workflows/snap-publish.yml` | Uploads existing snap and component artifacts to the Store without rebuilding. Release Dev calls it directly for `latest/edge` after snap builds and requires it to succeed before creating the dev release. Release Tag calls it for `latest/stable` only for stable releases, after qualification and release assembly succeed. |
554554
| `.github/workflows/release-canary.yml` | Smoke-tests published dev artifacts in the `macos`, `ubuntu-deb`, `ubuntu-snap-system-docker`, `fedora`, and `kubernetes` (kind + Helm) jobs. Each job reaches its gateway and creates, exercises, and deletes a sandbox. The `ubuntu-snap-system-docker` job verifies a compatible system Docker lifecycle, while `ubuntu-snap-docker-preflight` tests fail-fast behavior when Docker is absent or supplied by the Docker snap. The positive snap lane also runs a local policy containment check with the packaged prover. It runs automatically after `Release Dev` succeeds and supports manual dispatch (`gh workflow run release-canary.yml --ref <branch>`). See the `test-release-canary` skill for the playbook and local kind reproduction. |

‎CONTRIBUTING.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ Contributor and maintainer skills live in `.agents/skills/`. They are marked int
108108
| Reviewing | `watch-github-actions` | Monitor CI pipeline status and logs |
109109
| Reviewing | `launch-openshell-gator` | Launch and supervise OpenShell gator agents for issue and PR monitoring |
110110
| Reviewing | `test-release-canary` | Dispatch and iterate on the Release Canary workflow that smoke-tests published artifacts |
111+
| Maintenance | `release-openshell` | Pick the latest qualified prerelease and tag its commit as stable |
111112
| Triage | `triage-issue` | Assess, classify, and route community-filed issues |
112113
| Platform | `helm-dev-environment` | Start and manage the local Kubernetes development environment |
113114
| Platform | `tui-development` | Development guide for the ratatui-based terminal UI |

0 commit comments

Comments
 (0)