Repository navigation
Support DataDeps 1.0 and GZip 0.8 - #268
Merged
CarloLucibello merged 2 commits intoOct 21, 2026
Merged
Conversation
DataDeps 1.0 renamed `fetch_default` to `fetch` and moved `download(::DataDep, dir)` from `Base.download` to `Downloads.download`, so `DataDeps.download(...)` now resolves to `Base.download` and throws a MethodError. Pick the right functions at load time so both 0.7 and 1.0 work, and widen compat to `DataDeps = "0.7, 1"`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FEjYLhJeFY8SvquBAfpCST
The only breaking change in GZip 0.8 is `eof` after the last line, which the MNIST reader doesn't use (it only does binary reads via `gzopen`). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FEjYLhJeFY8SvquBAfpCST
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #268 +/- ##
==========================================
+ Coverage 45.94% 47.75% +1.80%
==========================================
Files 50 54 +4
Lines 2501 2689 +188
==========================================
+ Hits 1149 1284 +135
- Misses 1352 1405 +53 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widens two compat bounds that currently hold these packages back for downstream users:
DataDepsto 1.0 andGZipto 0.8.DataDeps 1.0 (
DataDeps = "0.7, 1")DataDeps 1.0 has two breaking changes that affect MLDatasets:
DataDeps.fetch_defaultwas removed. Its replacement isDataDeps.fetch(remote_path, local_dir; ...), which also returns the local path. It is used in the graph datasets (TUDataset, TemporalBrains, Traffic, WindMillEnergy, ChickenPox, MovieLens, OGBDataset).download(::DataDep, dir; ...)is now a method ofDownloads.download, notBase.download. On 1.0,DataDeps.download(...)resolves to plainBase.downloadand throws aMethodError. This breaksdatadirwith a user-supplieddiranddownload_dep.src/download.jlnow bindsdatadeps_fetch/datadeps_downloadat load time, based onisdefined(DataDeps, :fetch_default), so both 0.7 and 1.0 work. 0.7 is kept because many other packages (Transformers, FastAI, Embeddings, PalmerPenguins, UCIData, …) still require DataDeps 0.7. Requiring 1.0 would hold MLDatasets back for their users.GZip 0.8 (
GZip = "0.5, 0.6, 0.7, 0.8")GZip 0.8's only breaking change is that
eofreports end of stream right after the last line is read. The MNIST reader only callsgzopenand reads binary data, so it isn't affected.Testing
TUDataset("MUTAG"),ChickenPox(),MNIST(:test; dir=...)andMLDatasets.download_dep("MNIST", dir)all download and load.Release request
masteralready has the MAT 0.12 (#256), GZip 0.7 (#257) and FixedPointNumbers 0.9 (#259) widenings, none of which have been released yet. Could this go out together with them as 0.7.22?Dependabot hasn't proposed GZip 0.8 or DataDeps 1.0 because it is at its default limit of 5 open Julia PRs (#263–#267, all lower-bound bumps from July). Closing those would let it open new PRs again.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FEjYLhJeFY8SvquBAfpCST