Skip to content

StreamHandler shouldn't inherit from asynchat.async_chat #306

Description

@mattclarke

Makes testing a pain as need to be patched out.
Better to wrap an instance of async_chat and call methods on that.
An instance can probably be passed in through the constructor of StreamHandler and this means we can use a test double rather than using "patch".

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions