Skip to content

Commit ba7eebb

Browse files
CryptoJonesclaude
andauthored
fix(heads): surface LoadReport quarantine warnings on every head (USE-P1-3 / #30) (#71)
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1 parent 8b7431c commit ba7eebb

14 files changed

Lines changed: 98 additions & 26 deletions

File tree

‎ARCHITECTURE_REVIEW.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ in the trackers until the branch is merged.
8383
| SEC-P3-5 | **PARTIAL ON BRANCH** — threat model corrected; fail-open network defaults remain open | [Codeberg #139](https://codeberg.org/CryptoJones/Scylla/issues/139) · [GitHub #6](https://github.com/CryptoJones/Scylla/issues/6) |
8484
| USE-P1-1 | **RESOLVED ON BRANCH** — documented native prerequisites in README/CONTRIBUTING and added actionable panic messages to build.rs | [Codeberg #140](https://codeberg.org/CryptoJones/Scylla/issues/140) · [GitHub #29](https://github.com/CryptoJones/Scylla/issues/29) |
8585
| USE-P1-2 | **RESOLVED ON BRANCH** — setup guide added and personal path removed | [Codeberg #141](https://codeberg.org/CryptoJones/Scylla/issues/141) · [GitHub #9](https://github.com/CryptoJones/Scylla/issues/9) |
86-
| USE-P1-3 | **OPEN** | [Codeberg #142](https://codeberg.org/CryptoJones/Scylla/issues/142) · [GitHub #30](https://github.com/CryptoJones/Scylla/issues/30) |
86+
| USE-P1-3 | **RESOLVED ON BRANCH** — every head surfaces a dirty LoadReport (stderr warning; `load_warning` in wasm info) | [Codeberg #142](https://codeberg.org/CryptoJones/Scylla/issues/142) · [GitHub #30](https://github.com/CryptoJones/Scylla/issues/30) |
8787
| USE-P2-1 | **PARTIAL ON BRANCH** — parity overclaim removed; CLI mutation verbs remain absent | [Codeberg #143](https://codeberg.org/CryptoJones/Scylla/issues/143) · [GitHub #7](https://github.com/CryptoJones/Scylla/issues/7) |
8888
| USE-P2-2 | **OPEN** — docs no longer claim parity, but `merge` remains absent from seven heads | [Codeberg #144](https://codeberg.org/CryptoJones/Scylla/issues/144) · [GitHub #7](https://github.com/CryptoJones/Scylla/issues/7) |
8989
| USE-P2-3 | **OPEN** | [Codeberg #145](https://codeberg.org/CryptoJones/Scylla/issues/145) · [GitHub #31](https://github.com/CryptoJones/Scylla/issues/31) |
@@ -399,6 +399,7 @@ artifact, gets a silently reduced model, and receives **zero** warning — a dir
399399
platform's own ethos. **Advised:** after `Session::from_artifact`, if `!load_report().clean()`, emit a
400400
stderr warning (CLI/servers) / MCP notice / TUI status line with the counts; add a `--strict` that exits
401401
non-zero on a dirty load.
402+
**Remediated:** added `LoadReport::warning()`; cli, tui, lsp, mcp, http, graphql, and rpc-serve print it to stderr after load, and the wasm `scylla_info` JSON carries `load_warning`. `--strict` is not yet implemented.
402403

403404
### USE-P2-1 · The CLI cannot annotate at all, despite the "same verbs" claim
404405
`crates/scylla-cli/src/main.rs:29-42` dispatches only materialize/diff/info/functions/search/view/callers/

‎BACKLOG.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ _Status: 46/46 filed on Codeberg (#119–#164) and represented on GitHub (#4, #6
444444

445445
- [x] **[USE-P1-1]** A fresh clone fails to build on undocumented native prerequisites — [Codeberg #140](https://codeberg.org/CryptoJones/Scylla/issues/140) · [GitHub #29](https://github.com/CryptoJones/Scylla/issues/29) _(resolved: document native prerequisites in README/CONTRIBUTING and add actionable panic messages to build.rs)_ <!-- ISSUE:USE-P1-1 -->
446446
- [x] **[USE-P1-2]** engine-service (primary materialize path) has no setup docs and ships a hardcoded personal path — [Codeberg #141](https://codeberg.org/CryptoJones/Scylla/issues/141) · [GitHub #9](https://github.com/CryptoJones/Scylla/issues/9) _(resolved on `1012dcd`; pending merge)_ <!-- ISSUE:USE-P1-2 -->
447-
- [ ] **[USE-P1-3]** LoadReport quarantine warnings are silently dropped on every head — [Codeberg #142](https://codeberg.org/CryptoJones/Scylla/issues/142) · [GitHub #30](https://github.com/CryptoJones/Scylla/issues/30) <!-- ISSUE:USE-P1-3 -->
447+
- [x] **[USE-P1-3]** LoadReport quarantine warnings are silently dropped on every head — [Codeberg #142](https://codeberg.org/CryptoJones/Scylla/issues/142) · [GitHub #30](https://github.com/CryptoJones/Scylla/issues/30) _(resolved: every head surfaces a dirty LoadReport — stderr warning on cli/tui/lsp/mcp/http/graphql/rpc, `load_warning` in the wasm info)_ <!-- ISSUE:USE-P1-3 -->
448448
- [ ] **[USE-P2-1]** The CLI cannot annotate at all, despite the "same verbs" claim — [Codeberg #143](https://codeberg.org/CryptoJones/Scylla/issues/143) · [GitHub #7](https://github.com/CryptoJones/Scylla/issues/7) _(partial on `1012dcd`: overclaim removed; CLI mutation verbs remain absent)_ <!-- ISSUE:USE-P2-1 -->
449449
- [ ] **[USE-P2-2]** merge is missing from 7 of 9 heads — [Codeberg #144](https://codeberg.org/CryptoJones/Scylla/issues/144) · [GitHub #7](https://github.com/CryptoJones/Scylla/issues/7) <!-- ISSUE:USE-P2-2 -->
450450
- [ ] **[USE-P2-3]** The advertised collaborate (git-for-RE) verb is reachable from no head — [Codeberg #145](https://codeberg.org/CryptoJones/Scylla/issues/145) · [GitHub #31](https://github.com/CryptoJones/Scylla/issues/31) <!-- ISSUE:USE-P2-3 -->

‎CHANGELOG.md‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,13 @@ The *why* behind every decision lives in [DesignDecisions.md](DesignDecisions.md
99

1010
## [Unreleased]
1111

12+
## [0.7.12] — 2026-09-15
13+
14+
### Usability
15+
16+
- **Surface LoadReport quarantine on every head (USE-P1-3 / GH-30).**
17+
New `LoadReport::warning()` summarizes what the loader dropped or truncated. cli, tui, lsp, mcp, http, graphql, and rpc-serve print it to stderr after loading a partially-quarantined artifact; the wasm `scylla_info` JSON now carries `load_warning`.
18+
1219
## [0.7.11] — 2026-09-15
1320

1421
### Usability
@@ -403,7 +410,8 @@ The **durable core spine** — design-locked and prototype-de-risked, *not a pro
403410
zero silent mis-attachment, made a code invariant (`WRONG = 0`).
404411
- 33 design decisions locked with rationale; 20 tests, CI, CONTRIBUTING, SECURITY.
405412

406-
[Unreleased]: https://codeberg.org/CryptoJones/Scylla/compare/v0.7.11...HEAD
413+
[Unreleased]: https://codeberg.org/CryptoJones/Scylla/compare/v0.7.12...HEAD
414+
[0.7.12]: https://codeberg.org/CryptoJones/Scylla/compare/v0.7.11...v0.7.12
407415
[0.7.11]: https://codeberg.org/CryptoJones/Scylla/compare/v0.7.10...v0.7.11
408416
[0.7.10]: https://codeberg.org/CryptoJones/Scylla/compare/v0.7.9...v0.7.10
409417
[0.7.9]: https://codeberg.org/CryptoJones/Scylla/compare/v0.7.8...v0.7.9

‎Cargo.lock‎

Lines changed: 16 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Cargo.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ members = [
2121
]
2222

2323
[workspace.package]
24-
version = "0.7.11"
24+
version = "0.7.12"
2525
edition = "2021"
2626
license = "Apache-2.0"
2727
authors = ["Aaron K. Clark <cryptojones@owasp.org>"]

‎crates/scylla-cli/src/main.rs‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,14 @@ fn load_session(path: &str) -> Result<Session, ExitCode> {
108108
eprintln!("error: reading {path}: {e}");
109109
ExitCode::from(2)
110110
})?;
111-
Session::from_artifact(&bytes).map_err(|e| {
111+
let session = Session::from_artifact(&bytes).map_err(|e| {
112112
eprintln!("error: loading {path}: {e}");
113113
ExitCode::from(2)
114-
})
114+
})?;
115+
if let Some(w) = session.load_report().warning(path) {
116+
eprintln!("{w}");
117+
}
118+
Ok(session)
115119
}
116120

117121
/// `scylla info [--json] <artifact>` — the artifact's name, language, and function count (offline).
@@ -355,7 +359,11 @@ fn merge(base_path: &str, reanalysis_path: &str, out_path: &str) -> ExitCode {
355359
fn diff(a_path: &str, b_path: &str, json: bool) -> ExitCode {
356360
let load = |p: &str| -> Result<Session, String> {
357361
let bytes = std::fs::read(p).map_err(|e| format!("reading {p}: {e}"))?;
358-
Session::from_artifact(&bytes).map_err(|e| format!("loading {p}: {e}"))
362+
let s = Session::from_artifact(&bytes).map_err(|e| format!("loading {p}: {e}"))?;
363+
if let Some(w) = s.load_report().warning(p) {
364+
eprintln!("{w}");
365+
}
366+
Ok(s)
359367
};
360368
let (a, b) = match (load(a_path), load(b_path)) {
361369
(Ok(a), Ok(b)) => (a, b),

‎crates/scylla-graphql/src/main.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ fn main() -> ExitCode {
6868
return ExitCode::FAILURE;
6969
}
7070
};
71+
if let Some(w) = session.load_report().warning(&artifact) {
72+
eprintln!("scylla-graphql: {w}");
73+
}
7174

7275
// SCYLLA_GRAPHQL_TOKEN gates every request (DD-035); unset = OPEN (fine for a loopback dev
7376
// console, announced loudly otherwise).

‎crates/scylla-http/src/main.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,9 @@ fn main() -> ExitCode {
137137
return ExitCode::FAILURE;
138138
}
139139
};
140+
if let Some(w) = session.load_report().warning(&artifact) {
141+
eprintln!("scylla-http: {w}");
142+
}
140143

141144
// Access is gated by SCYLLA_HTTP_TOKEN (DD-035): every request must carry
142145
// `Authorization: Bearer <token>`. Unset = OPEN (anyone can query) — fine for a loopback dev

‎crates/scylla-lsp/src/main.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ fn main() -> ExitCode {
3838
return ExitCode::FAILURE;
3939
}
4040
};
41+
if let Some(w) = session.load_report().warning(&path) {
42+
eprintln!("scylla-lsp: {w}");
43+
}
4144

4245
let stdin = io::stdin();
4346
let mut reader = stdin.lock();

‎crates/scylla-mcp/src/main.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ fn main() {
2020
eprintln!("error: decoding artifact: {e}");
2121
std::process::exit(1);
2222
});
23+
if let Some(w) = session.load_report().warning(&path) {
24+
eprintln!("scylla-mcp: {w}");
25+
}
2326
let root = std::env::var_os("SCYLLA_MCP_ROOT")
2427
.map(PathBuf::from)
2528
.unwrap_or_else(|| {

0 commit comments

Comments
 (0)